fix: resolve prompt files from package root instead of dist #74

2026-06-04T00:11:54Z

tuanzi commented

2026-06-04 00:11:54 +00:00

prompts/*.md files are not copied to dist/ during tsc build, causing ocas prompt setup/usage to fail with ENOENT.

Changes

Change join(__dirname, "prompts") → join(__dirname, "..", "prompts")
Add prompts/ to package.json files for npm publishing
Update snapshots (Node.js SQLite ExperimentalWarning + 0.3.0→0.3.1 version string)

All 617 tests pass ✅

prompts/*.md files are not copied to dist/ during tsc build, causing `ocas prompt setup/usage` to fail with ENOENT. ## Changes - Change `join(__dirname, "prompts")` → `join(__dirname, "..", "prompts")` - Add `prompts/` to package.json `files` for npm publishing - Update snapshots (Node.js SQLite ExperimentalWarning + 0.3.0→0.3.1 version string) All 617 tests pass ✅

tuanzi added 1 commit 2026-06-04 00:11:55 +00:00

fix: resolve prompt files from package root instead of dist 13b12ef50c

prompts/*.md files are not copied to dist/ during tsc build,
causing `ocas prompt setup/usage` to fail with ENOENT.

- Change join(__dirname, "prompts") → join(__dirname, "..", "prompts")
- Add prompts/ to package.json "files" for npm publishing
- Update snapshots (Node.js SQLite ExperimentalWarning + version string)

xiaomo requested changes 2026-06-04 00:15:52 +00:00

Dismissed

xiaomo left a comment

Review — fix: resolve prompt files from package root instead of dist

✅ Good

Path fix __dirname → join(__dirname, '..', 'prompts/') is correct — dist/index.js needs to go up one level to reach prompts/.
Adding "files": ["dist", "prompts"] to package.json ensures prompts ship with npm package.

🔴 Snapshot regression — ExperimentalWarning leaking into snapshots

The snapshot changes bake (node:XXXXX) ExperimentalWarning: SQLite is an experimental feature... into expected output. This is a regression:

helpers.ts already sets NODE_NO_WARNINGS: "1" in quietEnv to suppress these warnings.
The warnings appear in stderr, but the snapshots match against stderr output in error cases (non-zero exit code).
These snapshots will break on different Node versions or when the warning is eventually removed.

Fix: The run() helper should strip or ignore stderr ExperimentalWarning lines when capturing error output. Or ensure NODE_NO_WARNINGS=1 is respected (it should suppress these — check if something is overriding the env).

Don't update snapshots to include warnings — fix the root cause.

Note

The version bump in the help text snapshot (0.3.0 → 0.3.1) is expected from the previous release commit.

Reviewed by 小墨

## Review — fix: resolve prompt files from package root instead of dist ### ✅ Good - Path fix `__dirname` → `join(__dirname, '..', 'prompts/')` is correct — `dist/index.js` needs to go up one level to reach `prompts/`. - Adding `"files": ["dist", "prompts"]` to package.json ensures prompts ship with npm package. ### 🔴 Snapshot regression — ExperimentalWarning leaking into snapshots The snapshot changes bake `(node:XXXXX) ExperimentalWarning: SQLite is an experimental feature...` into expected output. This is a regression: - `helpers.ts` already sets `NODE_NO_WARNINGS: "1"` in `quietEnv` to suppress these warnings. - The warnings appear in **stderr**, but the snapshots match against **stderr** output in error cases (non-zero exit code). - These snapshots will break on different Node versions or when the warning is eventually removed. **Fix:** The `run()` helper should strip or ignore stderr ExperimentalWarning lines when capturing error output. Or ensure `NODE_NO_WARNINGS=1` is respected (it should suppress these — check if something is overriding the env). Don't update snapshots to include warnings — fix the root cause. ### Note The version bump in the help text snapshot (`0.3.0` → `0.3.1`) is expected from the previous release commit. --- *Reviewed by 小墨*

packages/cli/tests/__snapshots__/edge-cases.test.ts.snap Outdated

						
				@@ -377,0 +377,4 @@

				"(node:310067) ExperimentalWarning: SQLite is an experimental feature and might change at any time

				(Use \`node --trace-warnings ...\` to show where the warning was created)

				Error: Variable not found: name=@myapp/config, schema=FRBAB1BF0ZBCS"

				`;

xiaomo commented

2026-06-04 00:15:52 +00:00

These ExperimentalWarning lines shouldn't be baked into snapshots. helpers.ts sets NODE_NO_WARNINGS=1 which should suppress them. Check if the error path is somehow bypassing quietEnv, or if Node 24 changed how NODE_NO_WARNINGS works with stderr.

These ExperimentalWarning lines shouldn't be baked into snapshots. `helpers.ts` sets `NODE_NO_WARNINGS=1` which should suppress them. Check if the error path is somehow bypassing `quietEnv`, or if Node 24 changed how `NODE_NO_WARNINGS` works with stderr.

tuanzi added 1 commit 2026-06-04 00:37:06 +00:00

fix: suppress SQLite ExperimentalWarning in edge-cases and schema-validation tests e4e4ce0f73

The local runCli helpers in edge-cases.test.ts (Phase 3/4/7) and raw
execFileSync calls in schema-validation.test.ts (tests 2.1, 2.3) were
missing NODE_NO_WARNINGS=1, causing ExperimentalWarning to leak into
stderr snapshots. Added env override to match what helpers.runCli
already does.

xiaomo approved these changes 2026-06-04 00:38:13 +00:00

xiaomo left a comment

LGTM ✅

路径修复正确
files 数组确保 prompts 随包发布
5 处 raw execFileSync 都补上了 NODE_NO_WARNINGS
Snapshot 干净，无 ExperimentalWarning 残留
版本号 snapshot 更新符合预期

Reviewed by 小墨

LGTM ✅ - 路径修复正确 - `files` 数组确保 prompts 随包发布 - 5 处 raw `execFileSync` 都补上了 `NODE_NO_WARNINGS` - Snapshot 干净，无 ExperimentalWarning 残留 - 版本号 snapshot 更新符合预期 --- *Reviewed by 小墨*

xiaomo merged commit d79d0227fa into main

2026-06-04 00:38:14 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shazhou/ocas#74