From 355594d07409e2854bd6e6571dcef59715d798e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=B0=8F=E6=A9=98?= <xiaoju@shazhou.work>
Date: Fri, 22 May 2026 05:31:43 +0000
Subject: [PATCH] refactor: graph fallback pattern + positive condition names
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Last transition in each graph node is now the fallback (no condition)
- Remove redundant positive conditions (ready, devDone, approved, passed, pushSuccess)
- notApproved → rejected (positive naming)
---
 .workflows/solve-issue.yaml | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)

diff --git a/.workflows/solve-issue.yaml b/.workflows/solve-issue.yaml
index 38863ab..7a52e81 100644
--- a/.workflows/solve-issue.yaml
+++ b/.workflows/solve-issue.yaml
@@ -125,36 +125,21 @@ conditions:
   insufficientInfo:
     description: "Planner determined there's not enough info to proceed"
     expression: "steps[-1].output.status = 'insufficient_info'"
-  ready:
-    description: "Planner produced a test spec"
-    expression: "steps[-1].output.status = 'ready'"
-  devDone:
-    description: "Developer finished implementation"
-    expression: "steps[-1].output.status = 'done'"
   devFailed:
     description: "Developer failed to implement"
     expression: "steps[-1].output.status = 'failed'"
-  notApproved:
+  rejected:
     description: "Reviewer rejected the implementation"
     expression: "steps[-1].output.approved = false"
-  approved:
-    description: "Reviewer approved the implementation"
-    expression: "steps[-1].output.approved = true"
   fixCode:
     description: "Tester found code issues"
     expression: "steps[-1].output.status = 'fix_code'"
   fixSpec:
     description: "Tester found spec issues"
     expression: "steps[-1].output.status = 'fix_spec'"
-  passed:
-    description: "Tester verified all scenarios pass"
-    expression: "steps[-1].output.status = 'passed'"
   hookFailed:
     description: "Push hook failed"
     expression: "steps[-1].output.success = false"
-  pushSuccess:
-    description: "Commit and PR created successfully"
-    expression: "steps[-1].output.success = true"
 graph:
   $START:
     - role: "planner"
@@ -163,26 +148,21 @@ graph:
     - role: "$END"
       condition: "insufficientInfo"
     - role: "developer"
-      condition: "ready"
   developer:
     - role: "$END"
       condition: "devFailed"
     - role: "reviewer"
-      condition: "devDone"
   reviewer:
     - role: "developer"
-      condition: "notApproved"
+      condition: "rejected"
     - role: "tester"
-      condition: "approved"
   tester:
     - role: "developer"
       condition: "fixCode"
     - role: "planner"
       condition: "fixSpec"
     - role: "committer"
-      condition: "passed"
   committer:
     - role: "developer"
       condition: "hookFailed"
     - role: "$END"
-      condition: "pushSuccess"