From aab846498b350ca4974fc81915c5393ce798a21a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=98=9F=E6=9C=88?= Date: Thu, 4 Jun 2026 17:36:45 +0800 Subject: [PATCH] =?UTF-8?q?fix:=20fix=207=20failing=20tests=20(OCAS=5FDIR?= =?UTF-8?q?=20=E2=86=92=20OCAS=5FHOME=20+=20restore=20workflow=20destructu?= =?UTF-8?q?re)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Root cause: tests used OCAS_DIR env var but store.ts reads OCAS_HOME, causing tests to hit the global ~/.ocas vars instead of temp dirs. - store-unified-threads.test.ts: OCAS_DIR → OCAS_HOME (3 tests) - thread-resume.test.ts: OCAS_DIR → OCAS_HOME (3 tests) - current-role.test.ts: restore { thread, workflow } destructure that was incorrectly removed by biome unsafe fix (1 test) Result: 745 passed, 0 failed, 1 skipped Closes #49 --- packages/cli/src/__tests__/current-role.test.ts | 2 +- packages/cli/src/__tests__/store-unified-threads.test.ts | 2 +- packages/cli/src/__tests__/thread-resume.test.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/cli/src/__tests__/current-role.test.ts b/packages/cli/src/__tests__/current-role.test.ts index 310a1aa..c234ed7 100644 --- a/packages/cli/src/__tests__/current-role.test.ts +++ b/packages/cli/src/__tests__/current-role.test.ts @@ -324,7 +324,7 @@ describe("currentRole field", () => { try { const wf = join(tmpDir, "test-current-role.yaml"); await writeFile(wf, SIMPLE_WORKFLOW_YAML, "utf8"); - const { thread } = await cmdThreadStart(storageRoot, wf, "test", tmpDir); + const { thread, workflow } = await cmdThreadStart(storageRoot, wf, "test", tmpDir); const tid = thread as ThreadId; await createMarker(storageRoot, { diff --git a/packages/cli/src/__tests__/store-unified-threads.test.ts b/packages/cli/src/__tests__/store-unified-threads.test.ts index 247db5d..be1647a 100644 --- a/packages/cli/src/__tests__/store-unified-threads.test.ts +++ b/packages/cli/src/__tests__/store-unified-threads.test.ts @@ -15,7 +15,7 @@ import { async function makeUwfStore(storageRoot: string) { const casDir = join(storageRoot, "cas"); await mkdir(casDir, { recursive: true }); - process.env.OCAS_DIR = casDir; + process.env.OCAS_HOME = casDir; return createUwfStore(storageRoot); } diff --git a/packages/cli/src/__tests__/thread-resume.test.ts b/packages/cli/src/__tests__/thread-resume.test.ts index 3b8aa9e..d53e4b6 100644 --- a/packages/cli/src/__tests__/thread-resume.test.ts +++ b/packages/cli/src/__tests__/thread-resume.test.ts @@ -491,7 +491,7 @@ describe("uwf thread resume - completed threads", () => { cwd: tmpDir, }); - process.env.OCAS_DIR = casDir; + process.env.OCAS_HOME = casDir; const workerOutputHash = await store.cas.put(outputSchemaHash, { $status: "_" }); const reviewerOutputHash = await store.cas.put(outputSchemaHash, { $status: "_" }); @@ -654,7 +654,7 @@ echo '${adapterJson}' cwd: tmpDir, }); - process.env.OCAS_DIR = casDir; + process.env.OCAS_HOME = casDir; await seedThreads(tmpDir, { [THREAD_ID]: { head: startHash, @@ -702,7 +702,7 @@ echo '${adapterJson}' cwd: tmpDir, }); - process.env.OCAS_DIR = casDir; + process.env.OCAS_HOME = casDir; await seedThreads(tmpDir, { [THREAD_ID]: startHash }); const result = runUwf(["thread", "resume", THREAD_ID], casDir);