From fd33bf5ee1604e1d29611d51e2a1a466e1dd32e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B0=8F=E6=A9=98?= Date: Wed, 3 Jun 2026 14:58:23 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20address=20PR=20review=20=E2=80=94=20awai?= =?UTF-8?q?t=20store.cas.put=20+=20bun=20shebang=20=E2=86=92=20node?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add missing await on store.cas.put() in run.ts:192 - Replace #!/usr/bin/env bun → #!/usr/bin/env node in all CLI bins - Update issue-551 test to assert node shebang --- packages/agent-builtin/src/cli.ts | 2 +- packages/agent-claude-code/src/cli.ts | 2 +- packages/agent-hermes/__tests__/issue-551.test.ts | 4 ++-- packages/agent-hermes/src/cli.ts | 2 +- packages/util-agent/src/run.ts | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/agent-builtin/src/cli.ts b/packages/agent-builtin/src/cli.ts index d3fda1e..57042b4 100755 --- a/packages/agent-builtin/src/cli.ts +++ b/packages/agent-builtin/src/cli.ts @@ -1,4 +1,4 @@ -#!/usr/bin/env bun +#!/usr/bin/env node import { createBuiltinAgent } from "./agent.js"; diff --git a/packages/agent-claude-code/src/cli.ts b/packages/agent-claude-code/src/cli.ts index eb28ec5..0e26393 100644 --- a/packages/agent-claude-code/src/cli.ts +++ b/packages/agent-claude-code/src/cli.ts @@ -1,4 +1,4 @@ -#!/usr/bin/env bun +#!/usr/bin/env node import { createClaudeCodeAgent } from "./claude-code.js"; diff --git a/packages/agent-hermes/__tests__/issue-551.test.ts b/packages/agent-hermes/__tests__/issue-551.test.ts index 0896e8c..761b656 100644 --- a/packages/agent-hermes/__tests__/issue-551.test.ts +++ b/packages/agent-hermes/__tests__/issue-551.test.ts @@ -12,11 +12,11 @@ describe("Issue #551 — bin entry & engines", () => { expect(pkg.engines?.bun).toBeUndefined(); }); - test("bin entry file has bun shebang", () => { + test("bin entry file has node shebang", () => { const pkg = JSON.parse(readFileSync(join(PKG_ROOT, "package.json"), "utf-8")); const binPath = pkg.bin["uwf-hermes"]; const content = readFileSync(join(PKG_ROOT, binPath), "utf-8"); - expect(content.startsWith("#!/usr/bin/env bun")).toBe(true); + expect(content.startsWith("#!/usr/bin/env node")).toBe(true); }); test("README.md explains uwf-hermes is an adapter", () => { diff --git a/packages/agent-hermes/src/cli.ts b/packages/agent-hermes/src/cli.ts index 39941d1..8e6d26e 100755 --- a/packages/agent-hermes/src/cli.ts +++ b/packages/agent-hermes/src/cli.ts @@ -1,4 +1,4 @@ -#!/usr/bin/env bun +#!/usr/bin/env node import { createHermesAgent } from "./hermes.js"; diff --git a/packages/util-agent/src/run.ts b/packages/util-agent/src/run.ts index c056e64..ae81038 100644 --- a/packages/util-agent/src/run.ts +++ b/packages/util-agent/src/run.ts @@ -192,7 +192,7 @@ export function createAgent(options: AgentOptions): () => Promise { let assembledPromptHash: CasRef | null = null; if (promptText !== "") { try { - assembledPromptHash = ctx.meta.store.cas.put(ctx.meta.schemas.text, promptText); + assembledPromptHash = await ctx.meta.store.cas.put(ctx.meta.schemas.text, promptText); } catch { assembledPromptHash = null; }