Remove Store.list() from interface #11

New Issue

2026-05-18T14:29:42Z

xiaoju commented

2026-05-18 14:29:42 +00:00

Summary

Remove list(): Hash[] from the Store interface. It encourages full CAS scans which are an O(n) performance trap.

Motivation

With listByType() now available, there is no legitimate use case for iterating all nodes. Any code using list() should be migrated to listByType() or removed.

Tasks

Remove list() from Store type in json-cas/src/types.ts
Remove implementation from json-cas/src/store.ts (memory store)
Remove implementation from json-cas-fs/src/store.ts (fs store)
Update/remove any tests that depend on list()
Check for internal usages (e.g. walk, refs, bootstrap) and migrate if needed

## Summary Remove `list(): Hash[]` from the `Store` interface. It encourages full CAS scans which are an O(n) performance trap. ## Motivation With `listByType()` now available, there is no legitimate use case for iterating all nodes. Any code using `list()` should be migrated to `listByType()` or removed. ## Tasks - [ ] Remove `list()` from `Store` type in `json-cas/src/types.ts` - [ ] Remove implementation from `json-cas/src/store.ts` (memory store) - [ ] Remove implementation from `json-cas-fs/src/store.ts` (fs store) - [ ] Update/remove any tests that depend on `list()` - [ ] Check for internal usages (e.g. `walk`, `refs`, `bootstrap`) and migrate if needed

xingyue referenced this issue from a commit

2026-05-18 17:24:18 +00:00

feat: remove Store.list() from interface

scottwei referenced a pull request that will close this issue

2026-05-18 17:24:32 +00:00

feat: remove Store.list() from interface #14

scottwei closed this issue

2026-05-25 01:35:02 +00:00

This repo is archived. You cannot comment on issues.