Addresses Review Round 2 feedback for variable model refactor:
1. Remove create() method - set() is now the unified entry point
2. Remove VariableDuplicateError class (only used by create())
3. Clean up dead code: Array.isArray(existing) checks in update()/remove()/tag()
4. Add tag/label conflict validation to set() update path
5. Migrate gc.test.ts from create() to set()
Changes:
- Delete create() method (lines 381-467) and VariableDuplicateError class
- Remove Array.isArray checks from 3 methods (always null, never array)
- Remove orphaned delete() JSDoc comment
- Add 3 new tests for set() update path tag/label conflict validation
- Replace 10 create() calls with set() in gc.test.ts
Test results: 193 pass (190 existing + 3 new)
Build: clean, Lint: clean
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xiaoju
5e7db0ef6b