uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(store): rename LogEntry.ts → LogEntry.timestamp #113

New Issue
Closed
opened 2026-04-25 01:58:31 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-04-25 01:58:31 +00:00
Owner
Copy Link
Copy Source

Background

#108 unified Signal.ts → Signal.timestamp and SenseInfo.lastSignalTs → SenseInfo.lastSignalTimestamp, but intentionally left LogEntry.ts unchanged because it is a DB column name.

For consistency, rename LogEntry.ts → LogEntry.timestamp as well.

Scope

  1. packages/store/src/types.ts — rename LogEntry.ts field to timestamp
  2. packages/store/src/log-store.ts — update all reads/writes of the field
  3. SQLite column: add a migration or alias (ts AS timestamp) to avoid breaking existing DBs
  4. All consumers across packages that reference LogEntry.ts (kernel, CLI, tests)
  5. Run pnpm run check && pnpm run build && pnpm -r run test

Notes

  • This is a DB schema change — need migration strategy (rename column or use SQL alias)
  • Existing .nerve databases in the wild have ts column, so backward compat matters
## Background #108 unified `Signal.ts` → `Signal.timestamp` and `SenseInfo.lastSignalTs` → `SenseInfo.lastSignalTimestamp`, but intentionally left `LogEntry.ts` unchanged because it is a DB column name. For consistency, rename `LogEntry.ts` → `LogEntry.timestamp` as well. ## Scope 1. `packages/store/src/types.ts` — rename `LogEntry.ts` field to `timestamp` 2. `packages/store/src/log-store.ts` — update all reads/writes of the field 3. **SQLite column**: add a migration or alias (`ts AS timestamp`) to avoid breaking existing DBs 4. All consumers across packages that reference `LogEntry.ts` (kernel, CLI, tests) 5. Run `pnpm run check && pnpm run build && pnpm -r run test` ## Notes - This is a DB schema change — need migration strategy (rename column or use SQL alias) - Existing `.nerve` databases in the wild have `ts` column, so backward compat matters
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?