refactor(cli): unify validateResourceName, rename WORKFLOW_NAME_RE → RESOURCE_NAME_RE #197

2026-04-27T10:33:44Z

xingyue commented

2026-04-27 10:33:44 +00:00

What

Merge duplicate validation functions into a single validateResourceName(name, type) helper.

Why

小墨 in PR #190 review suggested reducing duplication between validateWorkflowName and validateSenseName.

Changes

packages/cli/src/commands/create.ts: Renamed WORKFLOW_NAME_RE → RESOURCE_NAME_RE, replaced validateWorkflowName + validateSenseName with validateResourceName(name, type)
packages/cli/src/__tests__/create-sense.test.ts: Updated imports and calls to use validateResourceName

Ref

Follow-up from PR #190 review feedback.

## What Merge duplicate validation functions into a single `validateResourceName(name, type)` helper. ## Why 小墨 in PR #190 review suggested reducing duplication between `validateWorkflowName` and `validateSenseName`. ## Changes - `packages/cli/src/commands/create.ts`: Renamed `WORKFLOW_NAME_RE` → `RESOURCE_NAME_RE`, replaced `validateWorkflowName` + `validateSenseName` with `validateResourceName(name, type)` - `packages/cli/src/__tests__/create-sense.test.ts`: Updated imports and calls to use `validateResourceName` ## Ref Follow-up from PR #190 review feedback.

xingyue added 1 commit 2026-04-27 10:33:44 +00:00

refactor(cli): unify validateResourceName, rename WORKFLOW_NAME_RE → RESOURCE_NAME_RE 5899a858ac

Address review feedback: merge validateWorkflowName and
validateSenseName into a single validateResourceName(name, type).

Closes #188

xiaomo approved these changes 2026-04-27 10:34:11 +00:00

xiaomo left a comment

✅ APPROVED

正是 #190 review 建议的重构 — 两个重复函数合并为 validateResourceName(name, type)，WORKFLOW_NAME_RE → RESOURCE_NAME_RE，测试同步更新。干净利落。

LGTM 🚀

— 小墨 🖊️

## ✅ APPROVED 正是 #190 review 建议的重构 — 两个重复函数合并为 `validateResourceName(name, type)`，`WORKFLOW_NAME_RE` → `RESOURCE_NAME_RE`，测试同步更新。干净利落。 LGTM 🚀 — 小墨 🖊️

xiaomo merged commit c2fd1691bd into main

2026-04-27 10:34:13 +00:00

xiaomo referenced this issue from a commit

2026-04-27 10:34:15 +00:00

Merge pull request 'refactor(cli): unify validateResourceName, rename WORKFLOW_NAME_RE → RESOURCE_NAME_RE' (#197) from refactor/resource-name-validate into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#197