uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: dead code cleanup — unused exports, stale docs, deprecated functions #302

New Issue
Closed
opened 2026-04-30 14:26:45 +00:00 by xiaomo · 0 comments
xiaomo commented 2026-04-30 14:26:45 +00:00
Owner
Copy Link
Copy Source

Background

Dead code analysis (2026-04-30) found several unused exports, stale documentation, and deprecated code.

Full report: docs/dead-code-analysis.md

Tasks

High priority

  • Delete createEchoAgent — packages/daemon/src/agent-adapters/echo.ts exported but never referenced anywhere. Remove file + export from index.ts
  • Delete isDryRun — packages/workflow-utils/src/role-types.ts, deprecated, always returns false, zero callers. Remove from source + index.ts export
  • Clean up KNOWN_AGENT_ADAPTER_IDS — packages/core/src/agent.ts, never referenced. Either wire it into validation or remove. Contains codex with no adapter package
  • Fix packages/core/README.md — stale API names: parseSenseWorkflowDirective → parseWorkflowTrigger, ParsedSenseWorkflowDirective → current type, SenseComputeRoute → RoutedSenseOutput

API surface cleanup

  • Remove parseDurationStringToMs from core public export — only used internally in config.ts, no need to expose
  • Remove labelSenseTrigger from core public export — senseTriggerLabels is sufficient; labelSenseTrigger unused externally
  • Remove spawnSafe re-export from workflow-utils — all consumers import directly from @uncaged/nerve-core

Minor cleanup

  • Clean stale comment in packages/workflow-utils/src/shared/hermes-agent.ts referencing deleted hermes-options.ts

Verification

  • pnpm run build passes
  • pnpm test passes (all packages)
  • npx biome check . clean
## Background Dead code analysis (2026-04-30) found several unused exports, stale documentation, and deprecated code. Full report: `docs/dead-code-analysis.md` ## Tasks ### High priority - [ ] **Delete `createEchoAgent`** — `packages/daemon/src/agent-adapters/echo.ts` exported but never referenced anywhere. Remove file + export from `index.ts` - [ ] **Delete `isDryRun`** — `packages/workflow-utils/src/role-types.ts`, deprecated, always returns `false`, zero callers. Remove from source + `index.ts` export - [ ] **Clean up `KNOWN_AGENT_ADAPTER_IDS`** — `packages/core/src/agent.ts`, never referenced. Either wire it into validation or remove. Contains `codex` with no adapter package - [ ] **Fix `packages/core/README.md`** — stale API names: `parseSenseWorkflowDirective` → `parseWorkflowTrigger`, `ParsedSenseWorkflowDirective` → current type, `SenseComputeRoute` → `RoutedSenseOutput` ### API surface cleanup - [ ] **Remove `parseDurationStringToMs` from core public export** — only used internally in `config.ts`, no need to expose - [ ] **Remove `labelSenseTrigger` from core public export** — `senseTriggerLabels` is sufficient; `labelSenseTrigger` unused externally - [ ] **Remove `spawnSafe` re-export from `workflow-utils`** — all consumers import directly from `@uncaged/nerve-core` ### Minor cleanup - [ ] **Clean stale comment** in `packages/workflow-utils/src/shared/hermes-agent.ts` referencing deleted `hermes-options.ts` ## Verification - `pnpm run build` passes - `pnpm test` passes (all packages) - `npx biome check .` clean
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#302
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?