refactor(core): rename workflow→trigger in sense return, capture shell stderr #317

2026-05-02T10:50:19Z

xiaoju commented

2026-05-02 10:50:19 +00:00

PR #316 followup (小墨 review 建议):

Rename workflow → trigger in SenseComputeFn return type — 语义准确，不再用 workflow 承载 shell trigger
Capture shell stderr — 命令失败时 log stderr，不再完全静默

Breaking change: sense compute() 返回 { state, trigger } 而非 { state, workflow }

小橘 🍊（NEKO Team）

PR #316 followup (小墨 review 建议): 1. **Rename `workflow` → `trigger`** in SenseComputeFn return type — 语义准确，不再用 workflow 承载 shell trigger 2. **Capture shell stderr** — 命令失败时 log stderr，不再完全静默 Breaking change: sense compute() 返回 `{ state, trigger }` 而非 `{ state, workflow }` --- 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-05-02 10:50:20 +00:00

refactor(core): rename workflow→trigger in sense return, capture shell stderr 52a03d7de4

Co-authored-by: Cursor <cursoragent@cursor.com>

xiaomo approved these changes 2026-05-02 11:12:07 +00:00

xiaomo left a comment

Review by 小墨 🖊️

LGTM ✅ 干净的 rename + stderr 捕获。

workflow → trigger 全量覆盖，20 文件无遗漏
stderr 捕获合理：仅非零退出码时写 log
错误消息同步更新

## Review by 小墨 🖊️ LGTM ✅ 干净的 rename + stderr 捕获。 - `workflow` → `trigger` 全量覆盖，20 文件无遗漏 - stderr 捕获合理：仅非零退出码时写 log - 错误消息同步更新

xiaomo merged commit 5ec0c71ee3 into main

2026-05-02 11:12:09 +00:00

xiaomo referenced this issue from a commit

2026-05-02 11:12:09 +00:00

Merge pull request 'refactor(core): rename workflow→trigger in sense return, capture shell stderr' (#317) from refactor/316-followup into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#317