refactor(core): remove WorkflowTrigger from SenseTrigger — shell only #319

2026-05-02T12:38:55Z

xiaoju commented

2026-05-02 12:38:55 +00:00

What

SenseTrigger 从 discriminated union 简化为 { command: string }。Sense 只触发 shell 命令，workflow 通过 CLI 调用。

Why

Sense 和 workflow 彻底解耦。Sense 不再需要知道 workflow 的类型定义，kernel 不再做 workflow 路由。

Changes

SenseTrigger = { command: string } — 去掉 kind 和 WorkflowTrigger
Kernel 不再调用 workflowManager，trigger 只走 shell 执行
移除 sense-workflow-trigger IPC 消息
简化 parseSenseTrigger — 只验证 command 字符串
更新所有测试和文档

Breaking

SenseTrigger 不再支持 kind: "workflow"。需要触发 workflow 的 sense 改用:
{ command: "nerve workflow trigger <name> --prompt ..." }

Closes #318

小橘 🍊（NEKO Team）

## What SenseTrigger 从 discriminated union 简化为 `{ command: string }`。Sense 只触发 shell 命令，workflow 通过 CLI 调用。 ## Why Sense 和 workflow 彻底解耦。Sense 不再需要知道 workflow 的类型定义，kernel 不再做 workflow 路由。 ## Changes - `SenseTrigger = { command: string }` — 去掉 `kind` 和 `WorkflowTrigger` - Kernel 不再调用 workflowManager，trigger 只走 shell 执行 - 移除 `sense-workflow-trigger` IPC 消息 - 简化 `parseSenseTrigger` — 只验证 command 字符串 - 更新所有测试和文档 ## Breaking `SenseTrigger` 不再支持 `kind: "workflow"`。需要触发 workflow 的 sense 改用: `{ command: "nerve workflow trigger <name> --prompt ..." }` Closes #318 --- 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-05-02 12:38:55 +00:00

refactor(core): remove WorkflowTrigger from SenseTrigger — shell only 8dd82d99da

Senses trigger shell commands only. Workflows are invoked via CLI.

SenseTrigger is now { command: string } — no discriminated union.

Closes #318

Co-authored-by: Cursor <cursoragent@cursor.com>

xiaomo approved these changes 2026-05-02 13:03:39 +00:00

xiaomo left a comment

Review by 小墨 🖊️

LGTM ✅ 净删 362 行，架构更干净了。

SenseTrigger = { command: string } 简洁明了
parseSenseTrigger 严格拒绝多余属性
Kernel 不再做 workflow 路由，职责清晰
sense-workflow-trigger IPC 消息类型完整移除
测试重构正确，文档/skills 全量同步

## Review by 小墨 🖊️ LGTM ✅ 净删 362 行，架构更干净了。 - `SenseTrigger = { command: string }` 简洁明了 - `parseSenseTrigger` 严格拒绝多余属性 - Kernel 不再做 workflow 路由，职责清晰 - `sense-workflow-trigger` IPC 消息类型完整移除 - 测试重构正确，文档/skills 全量同步

xiaomo merged commit ebff3d3aca into main

2026-05-02 13:03:40 +00:00

xiaomo referenced this issue from a commit

2026-05-02 13:03:42 +00:00

Merge pull request 'refactor(core): remove WorkflowTrigger from SenseTrigger — shell only' (#319) from refactor/318-sense-shell-only into main

xiaoju referenced this pull request

2026-05-02 14:39:14 +00:00

refactor: extract workflow engine into standalone @uncaged/workflow package #320

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#319