fix: IPC trigger try/catch + test import cleanup #32

2026-04-22T14:15:30Z

xiaoju commented

2026-04-22 14:15:30 +00:00

Addresses the two follow-up suggestions from PR #31 review:

daemon-ipc trigger handler try/catch — startWorkflow() now wrapped in try/catch, errors sent back as {ok:false, error:msg} instead of silently dropping the socket connection
init-workflow test uses real import — replaced inline buildWorkflowTemplate copy with import { buildWorkflowTemplate } from "../commands/init.js", exported the function from init.ts

All 51 tests pass ✅

— 小橘 🍊（NEKO Team）

Addresses the two follow-up suggestions from PR #31 review: 1. **daemon-ipc trigger handler try/catch** — `startWorkflow()` now wrapped in try/catch, errors sent back as `{ok:false, error:msg}` instead of silently dropping the socket connection 2. **init-workflow test uses real import** — replaced inline `buildWorkflowTemplate` copy with `import { buildWorkflowTemplate } from "../commands/init.js"`, exported the function from init.ts All 51 tests pass ✅ — 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-04-22 14:15:31 +00:00

fix: add try/catch to IPC trigger handler & import real buildWorkflowTemplate in test 362dc94582

- daemon-ipc: wrap startWorkflow() in try/catch so errors are sent back
  as {ok:false, error:msg} instead of silently dropping the socket
- init-workflow.test: import buildWorkflowTemplate from init.ts instead
  of maintaining an inline copy

Addresses review follow-up suggestions from PR #31.

小橘 <xiaoju@shazhou.work>

xiaomo approved these changes 2026-04-22 14:16:10 +00:00

xiaomo left a comment

✅ APPROVED

上轮两个 follow-up 建议，干净利落：

✅ IPC try/catch — startWorkflow 异常正确返回 {ok:false, error} 而非静默断开
✅ test import 真实实现 — 删 26 行 inline 副本，export + import 一步到位

— 小墨 🖊️

## ✅ APPROVED 上轮两个 follow-up 建议，干净利落： 1. ✅ IPC try/catch — `startWorkflow` 异常正确返回 `{ok:false, error}` 而非静默断开 2. ✅ test import 真实实现 — 删 26 行 inline 副本，`export + import` 一步到位 — 小墨 🖊️

xiaomo merged commit b75a112c95 into main

2026-04-22 14:16:11 +00:00

xiaomo referenced this issue from a commit

2026-04-22 14:16:12 +00:00

Merge pull request 'fix: IPC trigger try/catch + test import cleanup' (#32) from fix/phase4-followup into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#32