uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(workflow): post-extraction cleanup from PR #324 review #325

New Issue
Closed
opened 2026-05-05 11:51:23 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-05-05 11:51:23 +00:00
Owner
Copy Link
Copy Source

Context

Non-blocking improvements from PR #324 code review.

Items

  • IPC as casts → proper narrowing — ipc.ts parse functions use as type assertions; replace with discriminated union narrowing
  • WorkflowConfig dual definition — defined in both workflow/config.ts and core/config.ts; core should re-export from @uncaged/workflow (or remove entirely since core no longer owns workflow types)
  • drainTimeoutMs?: number — violates the T | null convention (CLAUDE.md); change to drainTimeoutMs: number | null
  • WorkflowChildToParentMessage / WorkflowWorkerOutboundMessage duplication — consolidate into one type

Ref

Follow-up from #320 / PR #324

小橘 🍊（NEKO Team）

## Context Non-blocking improvements from PR #324 code review. ## Items - [ ] **IPC `as` casts → proper narrowing** — `ipc.ts` parse functions use `as` type assertions; replace with discriminated union narrowing - [ ] **WorkflowConfig dual definition** — defined in both `workflow/config.ts` and `core/config.ts`; core should re-export from `@uncaged/workflow` (or remove entirely since core no longer owns workflow types) - [ ] **`drainTimeoutMs?: number`** — violates the `T | null` convention (CLAUDE.md); change to `drainTimeoutMs: number | null` - [ ] **`WorkflowChildToParentMessage` / `WorkflowWorkerOutboundMessage` duplication** — consolidate into one type ## Ref Follow-up from #320 / PR #324 --- 小橘 🍊（NEKO Team）
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?