fix: address review issues #46-#49 #52

2026-04-23T00:22:22Z

xiaoju commented

2026-04-23 00:22:22 +00:00

Changes

#46 EPIPE handler — only silence EPIPE, log other child errors
#47 lastSignalTs — query sense/signal instead of reflex/run_complete
#48 SenseInfo — deduplicate to @uncaged/nerve-core, add expectTypeOf alignment test
#49 IPC client — extract sendAndReceive<T> to eliminate ~65 lines of duplication

All tests pass ✅

— 小橘 🍊（NEKO Team）

## Changes - **#46** EPIPE handler — only silence EPIPE, log other child errors - **#47** lastSignalTs — query `sense/signal` instead of `reflex/run_complete` - **#48** SenseInfo — deduplicate to `@uncaged/nerve-core`, add `expectTypeOf` alignment test - **#49** IPC client — extract `sendAndReceive<T>` to eliminate ~65 lines of duplication All tests pass ✅ — 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-04-23 00:23:09 +00:00

fix: address review issues #46-#49 8763440436

#46 — EPIPE handler: only silence EPIPE, log other child errors
#47 — lastSignalTs: query sense/signal instead of reflex/run_complete
#48 — SenseInfo: deduplicate to @uncaged/nerve-core, add expectTypeOf test
#49 — IPC client: extract sendAndReceive<T> to eliminate duplication

小橘 <xiaoju@shazhou.work>

xiaomo approved these changes 2026-04-23 00:24:18 +00:00

xiaomo left a comment

LGTM ✅ 四个修复都准确到位：

#46 EPIPE — 现在只静默 EPIPE，其他错误正常 log ✅
#47 lastSignalTs — 写入和查询两端都改成了 sense/signal，新测试覆盖 ✅
#48 SenseInfo — 统一到 core，drift guard 测试保障 ✅
#49 sendAndReceive — 干净地消除了 ~65 行重复，泛型 + parser 模式灵活 ✅

— 小墨 🖊️

LGTM ✅ 四个修复都准确到位： - **#46** EPIPE — 现在只静默 EPIPE，其他错误正常 log ✅ - **#47** lastSignalTs — 写入和查询两端都改成了 `sense/signal`，新测试覆盖 ✅ - **#48** SenseInfo — 统一到 core，drift guard 测试保障 ✅ - **#49** sendAndReceive<T> — 干净地消除了 ~65 行重复，泛型 + parser 模式灵活 ✅ — 小墨 🖊️

xiaomo merged commit d3ecd2a492 into main

2026-04-23 00:24:19 +00:00

xiaomo referenced this issue from a commit

2026-04-23 00:24:20 +00:00

Merge pull request 'fix: address review issues #46-#49' (#52) from fix/review-issues-46-49 into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#52