uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

PR #81 Review Follow-ups: 重复函数、双重 cast、SQL round 偏移 #83

New Issue
Closed
opened 2026-04-24 11:04:45 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-04-24 11:04:45 +00:00
Owner
Copy Link
Copy Source

来源

PR #81 Review 提出的 3 个 Warning + 2 个建议

🔴 高优：getThreadRoundCount SQL 未过滤 start 新格式

  • getThreadRoundCount SQL 查询没有过滤新格式的 __start__ 消息
  • 会导致 round 编号偏移，影响运行时逻辑
  • 需要在 SQL WHERE 子句中排除 __start__ 类型的消息

🟡 中优：parseWorkflowField 与 parseSenseWorkflowDirective 重复

  • parseWorkflowField（core/index.ts）和 parseSenseWorkflowDirective（core/sense-workflow-directive.ts）功能重复
  • 前者无校验，应合并到后者并删除前者
  • 统一使用 parseSenseWorkflowDirective

🟡 中优：workflow-worker.ts 不必要的双重 cast

  • as unknown as Record<string, unknown> 双重 cast 应简化
  • 检查是否能直接用类型断言或改进类型定义消除

🟢 低优：meta runtime validation

  • 考虑对 Role meta 添加运行时校验

🟢 低优：DEFAULT_ENGINE_MAX_ROUNDS 导出位置

  • 常量应从更合适的位置导出

— 小橘 🍊（NEKO Team）

## 来源 PR #81 Review 提出的 3 个 Warning + 2 个建议 ## 🔴 高优：getThreadRoundCount SQL 未过滤 __start__ 新格式 - `getThreadRoundCount` SQL 查询没有过滤新格式的 `__start__` 消息 - 会导致 round 编号偏移，影响运行时逻辑 - 需要在 SQL WHERE 子句中排除 `__start__` 类型的消息 ## 🟡 中优：parseWorkflowField 与 parseSenseWorkflowDirective 重复 - `parseWorkflowField`（core/index.ts）和 `parseSenseWorkflowDirective`（core/sense-workflow-directive.ts）功能重复 - 前者无校验，应合并到后者并删除前者 - 统一使用 `parseSenseWorkflowDirective` ## 🟡 中优：workflow-worker.ts 不必要的双重 cast - `as unknown as Record<string, unknown>` 双重 cast 应简化 - 检查是否能直接用类型断言或改进类型定义消除 ## 🟢 低优：meta runtime validation - 考虑对 Role meta 添加运行时校验 ## 🟢 低优：DEFAULT_ENGINE_MAX_ROUNDS 导出位置 - 常量应从更合适的位置导出 — 小橘 🍊（NEKO Team）
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#83
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?