uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

test: add unit tests for validateWorkflowDescriptor #19

New Issue
Closed
opened 2026-05-07 02:00:26 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-05-07 02:00:26 +00:00
Owner
Copy Link
Copy Source

Background

validateWorkflowDescriptor in packages/workflow/src/workflow-descriptor.ts has no unit tests. This function validates the structure of workflow descriptors exported from bundles, covering multiple error paths.

Task

Add packages/workflow/__tests__/workflow-descriptor.test.ts with tests covering:

  • Valid descriptor returns ok with parsed value
  • Rejects non-object descriptor (null, array, string, number)
  • Rejects missing/non-string description
  • Rejects missing/invalid roles (null, array, non-object)
  • Rejects individual role with missing/non-string description
  • Rejects individual role with missing/invalid schema
  • Empty roles object should be valid

Acceptance Criteria

  • bun test passes including the new test file
  • bun run check (biome) passes

—— 小橘 🍊（NEKO Team）

## Background `validateWorkflowDescriptor` in `packages/workflow/src/workflow-descriptor.ts` has no unit tests. This function validates the structure of workflow descriptors exported from bundles, covering multiple error paths. ## Task Add `packages/workflow/__tests__/workflow-descriptor.test.ts` with tests covering: - Valid descriptor returns `ok` with parsed value - Rejects non-object descriptor (null, array, string, number) - Rejects missing/non-string `description` - Rejects missing/invalid `roles` (null, array, non-object) - Rejects individual role with missing/non-string `description` - Rejects individual role with missing/invalid `schema` - Empty roles object should be valid ## Acceptance Criteria - `bun test` passes including the new test file - `bun run check` (biome) passes —— 小橘 🍊（NEKO Team）
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#19
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?