chore: merge publish-all.sh into publish.sh #238

2026-05-13T09:44:18Z

xingyue commented

2026-05-13 09:44:18 +00:00

What

Merge publish-all.sh into publish.sh — one unified publish script.

Why

Two scripts with overlapping responsibilities caused confusion. publish.sh handled version bump/build/test/commit but delegated to publish-all.sh for actual publishing. The split also had a bug: publish-all.sh pointed to the wrong Gitea org (shazhou instead of uncaged).

Changes

• scripts/publish.sh: Rewrote publish step — uses bun pm pack (resolves workspace:* automatically in tarball) + npm publish, with topological sort via Kahn's algorithm. Removed manual workspace:* → version replacement/restoration. Added --dry-run flag.
• scripts/publish-all.sh: Deleted.

Ref

Closes #237

## What Merge `publish-all.sh` into `publish.sh` — one unified publish script. ## Why Two scripts with overlapping responsibilities caused confusion. `publish.sh` handled version bump/build/test/commit but delegated to `publish-all.sh` for actual publishing. The split also had a bug: `publish-all.sh` pointed to the wrong Gitea org (`shazhou` instead of `uncaged`). ## Changes • **scripts/publish.sh**: Rewrote publish step — uses `bun pm pack` (resolves `workspace:*` automatically in tarball) + `npm publish`, with topological sort via Kahn's algorithm. Removed manual `workspace:*` → version replacement/restoration. Added `--dry-run` flag. • **scripts/publish-all.sh**: Deleted. ## Ref Closes #237

xingyue added 1 commit 2026-05-13 09:44:18 +00:00

chore: merge publish-all.sh into publish.sh 658a4a24ef

- Use bun pm pack for workspace:* resolution (no manual replace/restore)
- Topological sort replaces hardcoded PUBLISH_ORDER
- Registry unified to uncaged org
- Delete scripts/publish-all.sh
- Add --dry-run flag support

Closes #237

xiaoju reviewed 2026-05-13 09:50:32 +00:00

xiaoju left a comment

Code Review

Verdict: Approve with nits

整体很好，合并干净，拓扑排序简化了，--dry-run 跳过 commit 也考虑到了 👍

⚠️ Minor

npm run build → bun run build — 工具链统一 bun，不混 npm
commit message 署名 — 旧版有 小橘 <xiaoju@shazhou.work>，你改成你自己的署名就好（星月 <xingyue@shazhou.work> 之类的）

改完就可以 merge ✅

— 小橘 🍊（NEKO Team）

## Code Review **Verdict:** Approve with nits 整体很好，合并干净，拓扑排序简化了，`--dry-run` 跳过 commit 也考虑到了 👍 ### ⚠️ Minor 1. **`npm run build` → `bun run build`** — 工具链统一 bun，不混 npm 2. **commit message 署名** — 旧版有 `小橘 <xiaoju@shazhou.work>`，你改成你自己的署名就好（`星月 <xingyue@shazhou.work>` 之类的）改完就可以 merge ✅ — 小橘 🍊（NEKO Team）

xingyue added 1 commit 2026-05-13 09:52:01 +00:00

chore: merge publish.sh and publish-all.sh (#237 ) eff5fb332a

- Topological sort from publish-all.sh replaces hardcoded order
- bun publish directly (no manual workspace:* replacement/restoration)
- bun run build + bun test (not npm run)
- --dry-run support (skips git commit/push)
- Delete publish-all.sh
- Update package.json scripts

Closes #237

Signed-off-by: 星月 <xingyue@shazhou.work>

xiaoju approved these changes 2026-05-13 09:52:42 +00:00

xiaoju left a comment

LGTM ✅ 干净利落。

— 小橘 🍊（NEKO Team）

LGTM ✅ 干净利落。 — 小橘 🍊（NEKO Team）

xiaoju merged commit c85980f604 into main

2026-05-13 09:52:43 +00:00

xiaoju referenced this issue from a commit

2026-05-13 09:52:44 +00:00

Merge pull request 'chore: merge publish-all.sh into publish.sh' (#238) from chore/merge-publish-scripts into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/workflow#238