uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix biome cognitive complexity warnings #287

Merged
xingyue merged 1 commits from chore/fix-biome-complexity-warnings into main 2026-05-16 10:40:28 +00:00
Conversation 0 Commits 1 Files Changed 4
+436 -349
scottwei commented 2026-05-16 10:33:22 +00:00
Owner
Copy Link
Copy Source

Summary

  • Resolves 7 Biome noExcessiveCognitiveComplexity warnings so bun run check completes without warnings.
  • Extracts helpers in dashboard (thread-detail, workflow-detail, workflow-graph/use-layout) and workflow-register descriptor validation; behavior unchanged.
  • Removes a forbidden non-null assertion on queue.shift() in graph layout.

Test plan

  • bun run check (tsc + biome + log tags)
  • Dashboard smoke: thread detail graph node click scroll/highlight
  • Dashboard smoke: workflow detail schema table and graph layout render correctly
## Summary - Resolves 7 Biome `noExcessiveCognitiveComplexity` warnings so `bun run check` completes without warnings. - Extracts helpers in dashboard (`thread-detail`, `workflow-detail`, `workflow-graph/use-layout`) and `workflow-register` descriptor validation; behavior unchanged. - Removes a forbidden non-null assertion on `queue.shift()` in graph layout. ## Test plan - [x] `bun run check` (tsc + biome + log tags) - [ ] Dashboard smoke: thread detail graph node click scroll/highlight - [ ] Dashboard smoke: workflow detail schema table and graph layout render correctly
scottwei added 1 commit 2026-05-16 10:33:23 +00:00
chore: fix biome cognitive complexity warnings defc0afc27 
Refactor dashboard graph/schema helpers and descriptor role validation
into smaller functions so bun run check passes without warnings.

Co-authored-by: Cursor <cursoragent@cursor.com>
xingyue merged commit 9584a86fb7 into main 2026-05-16 10:40:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#287
Delete Branch "chore/fix-biome-complexity-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?