uncaged/workflow
Archived
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

bug: workflow roles share git worktree, causing cross-issue context pollution #395

New Issue
Closed
opened 2026-05-22 10:39:34 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-05-22 10:39:34 +00:00
Owner
Copy Link
Copy Source

Problem

All roles in a solve-issue thread share the same git worktree. When a previous thread/branch left uncommitted or unmerged changes, subsequent roles see stale diffs from unrelated issues.

Observed

Thread for #335 (setup model validation): reviewer's output discusses feat/373-thread-step-count files instead of the #335 changes. The developer for #335 wrote new code, but the worktree still had #373 branch artifacts, so the reviewer reviewed the wrong diff.

Impact

  • Reviewer approves/rejects based on wrong code
  • Tester may test wrong functionality
  • Committer may commit unrelated changes

Possible Fixes

  1. Workflow YAML procedure: developer role should git checkout main && git pull and create a fresh branch before starting work
  2. Engine-level: thread start or first thread step could auto-create a git worktree/branch
  3. Procedure guard: reviewer should verify the current branch matches the issue before reviewing

Option 1 is simplest — update solve-issue.yaml developer procedure to always start from clean main.

— 小橘 🍊（NEKO Team）

## Problem All roles in a solve-issue thread share the same git worktree. When a previous thread/branch left uncommitted or unmerged changes, subsequent roles see stale diffs from unrelated issues. ## Observed Thread for #335 (setup model validation): reviewer's output discusses `feat/373-thread-step-count` files instead of the #335 changes. The developer for #335 wrote new code, but the worktree still had #373 branch artifacts, so the reviewer reviewed the wrong diff. ## Impact - Reviewer approves/rejects based on wrong code - Tester may test wrong functionality - Committer may commit unrelated changes ## Possible Fixes 1. **Workflow YAML procedure**: developer role should `git checkout main && git pull` and create a fresh branch before starting work 2. **Engine-level**: `thread start` or first `thread step` could auto-create a git worktree/branch 3. **Procedure guard**: reviewer should verify the current branch matches the issue before reviewing Option 1 is simplest — update solve-issue.yaml developer procedure to always start from clean main. — 小橘 🍊（NEKO Team）
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?