uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Phase 1 Testing: HermesAcpClient class (RFC #398) #399

New Issue
Closed
opened 2026-05-22 12:11:19 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-05-22 12:11:19 +00:00
Owner
Copy Link
Copy Source

Verification Goal

A standalone HermesAcpClient class can spawn hermes acp, establish a session, send a prompt, and collect the response.

Test Steps

  • Step 1: Unit test — initialize + session/new

    cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts

    Expected: Test passes. Client can initialize and create a session, returning a valid sessionId (UUID format).

  • Step 2: Unit test — session/prompt and text collection

    cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts

    Expected: Test sends a prompt and collects the full response text from agent_message_chunk updates.

  • Step 3: Unit test — session resume (second prompt on same session)

    cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts

    Expected: Second prompt on same sessionId works, returns new response text.

  • Step 4: Build passes

    cd ~/repos/workflow && bun run --filter @uncaged/workflow-agent-hermes build

    Expected: TypeScript compilation succeeds with no errors.

Completion Criteria

✅ All test checkboxes pass
✅ Build succeeds
✅ No changes to existing hermes.ts yet (additive only)

Ref

Phase 1 of RFC #398

## Verification Goal A standalone `HermesAcpClient` class can spawn `hermes acp`, establish a session, send a prompt, and collect the response. ## Test Steps - [ ] **Step 1: Unit test — initialize + session/new** ```bash cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts ``` **Expected:** Test passes. Client can initialize and create a session, returning a valid sessionId (UUID format). - [ ] **Step 2: Unit test — session/prompt and text collection** ```bash cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts ``` **Expected:** Test sends a prompt and collects the full response text from `agent_message_chunk` updates. - [ ] **Step 3: Unit test — session resume (second prompt on same session)** ```bash cd ~/repos/workflow && bun test packages/workflow-agent-hermes/__tests__/acp-client.test.ts ``` **Expected:** Second prompt on same sessionId works, returns new response text. - [ ] **Step 4: Build passes** ```bash cd ~/repos/workflow && bun run --filter @uncaged/workflow-agent-hermes build ``` **Expected:** TypeScript compilation succeeds with no errors. ## Completion Criteria ✅ All test checkboxes pass ✅ Build succeeds ✅ No changes to existing `hermes.ts` yet (additive only) ## Ref Phase 1 of RFC #398
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?