uncaged/workflow
Archived
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(cli-workflow): implement multi-strategy workflow resolution #436

Closed
xiaoju wants to merge 1 commits from feat/428-workflow-resolution into main
pull from: feat/428-workflow-resolution
merge into: uncaged:main
Conversation 1 Commits 1 Files Changed 63
+1068 -612
xiaoju commented 2026-05-23 11:06:28 +00:00
Owner
Copy Link
Copy Source

What

Implements a 4-strategy workflow resolution system for the uwf CLI that provides flexible workflow loading options.

Why

Resolves issue #428 by allowing workflows to be referenced via CAS hash, explicit file path, local directory discovery, or global registry - improving developer experience and workflow portability.

Changes

  • Add 4-strategy resolution priority: CAS hash to file path to local discovery to global registry
  • Add helper functions: isFilePath, workflowFileExists, findWorkflowInDir, findWorkflowInParents
  • Refactor resolveWorkflowCasRef to support all four strategies
  • Add comprehensive test suite with 24 tests covering all strategies and edge cases
  • Support .workflow/ and .workflows/ directories with .yaml/.yml extensions
  • All 60 tests pass across 5 test files

Ref

Fixes #428

## What Implements a 4-strategy workflow resolution system for the uwf CLI that provides flexible workflow loading options. ## Why Resolves issue #428 by allowing workflows to be referenced via CAS hash, explicit file path, local directory discovery, or global registry - improving developer experience and workflow portability. ## Changes - Add 4-strategy resolution priority: CAS hash to file path to local discovery to global registry - Add helper functions: isFilePath, workflowFileExists, findWorkflowInDir, findWorkflowInParents - Refactor resolveWorkflowCasRef to support all four strategies - Add comprehensive test suite with 24 tests covering all strategies and edge cases - Support .workflow/ and .workflows/ directories with .yaml/.yml extensions - All 60 tests pass across 5 test files ## Ref Fixes #428
xiaoju added 1 commit 2026-05-23 11:06:28 +00:00
feat(cli-workflow): implement multi-strategy workflow resolution for issue #428 c0cefc48fb 
- Add 4-strategy resolution priority: CAS hash → file path → local discovery → global registry
- Add helper functions: isFilePath, workflowFileExists, findWorkflowInDir, findWorkflowInParents
- Refactor resolveWorkflowCasRef to support direct hash, explicit paths, and parent traversal
- Add comprehensive test suite with 24 tests covering all strategies and edge cases
- Support .workflow/ and .workflows/ directories with .yaml/.yml extensions
- All 60 tests pass across 5 test files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xiaomo approved these changes 2026-05-23 11:09:19 +00:00
xiaomo left a comment
Owner

LGTM ✅ 四级解析顺序实现正确，测试覆盖充分（367 行测试，所有策略+边界用例都覆盖了）。

⚠️ Minor

findWorkflowInParents 的 JSDoc 声称会在 .git 目录停止向上遍历，但代码未实现。建议补上 .git 停止逻辑或修正注释——在 monorepo 里不停可能会意外穿越 repo 边界。

不阻塞合入，follow-up 修即可。

LGTM ✅ 四级解析顺序实现正确，测试覆盖充分（367 行测试，所有策略+边界用例都覆盖了）。 ### ⚠️ Minor `findWorkflowInParents` 的 JSDoc 声称会在 `.git` 目录停止向上遍历，但代码未实现。建议补上 `.git` 停止逻辑或修正注释——在 monorepo 里不停可能会意外穿越 repo 边界。 不阻塞合入，follow-up 修即可。
xiaoju closed this pull request 2026-05-23 11:12:21 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#436
Delete Branch "feat/428-workflow-resolution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?