uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: reduce complexity in workflow-dashboard #449

New Issue
Closed
opened 2026-05-23 14:40:09 +00:00 by xingyue · 0 comments
xingyue commented 2026-05-23 14:40:09 +00:00
Owner
Copy Link
Copy Source

Split from #444.

Refactor 5 items in packages/workflow-dashboard/src/editor/:

  • layout/index.ts:52 assignLayers (26 → ≤15)
  • model/handlers.ts:33 onBeforeDelete (20 → ≤15)
  • model/handlers.ts:99 handleKeyDown (23 → ≤15)
  • trans/trans-in.ts:31 transIn (33 → ≤15)
  • trans/validate.ts:94 validateRoleNodes (22 → ≤15)
  • panel/add-node.tsx:22 Form — remove unused state parameter

Strategy: extract helper functions, early returns.
Keep existing tests green.

Split from #444. Refactor 5 items in `packages/workflow-dashboard/src/editor/`: - `layout/index.ts:52 assignLayers` (26 → ≤15) - `model/handlers.ts:33 onBeforeDelete` (20 → ≤15) - `model/handlers.ts:99 handleKeyDown` (23 → ≤15) - `trans/trans-in.ts:31 transIn` (33 → ≤15) - `trans/validate.ts:94 validateRoleNodes` (22 → ≤15) - `panel/add-node.tsx:22 Form` — remove unused `state` parameter Strategy: extract helper functions, early returns. Keep existing tests green.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?