uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

solve-issue workflow: developer 缺少 check 步骤导致 reviewer 每次打回 #477

New Issue
Closed
opened 2026-05-24 16:24:52 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-05-24 16:24:52 +00:00
Owner
Copy Link
Copy Source

问题

solve-issue workflow 中 developer 的 procedure 没有要求运行 bun run check（tsc + biome + lint-log-tags），导致 reviewer 每次都能抓到 lint 错误并打回，浪费一轮 developer→reviewer 循环。

观察

  • #471: reviewer 第一次打回（25 个 biome 错误、forEach 违规）
  • #473: 类似模式

修复方向

  1. developer procedure 加一步：提交前运行 bun run check，修复所有错误
  2. reviewer procedure 明确区分 hard check（build/lint 必须过）和 soft check（代码质量），让 developer 自己先过 hard check

小橘 🍊（NEKO Team）

## 问题 solve-issue workflow 中 developer 的 procedure 没有要求运行 `bun run check`（tsc + biome + lint-log-tags），导致 reviewer 每次都能抓到 lint 错误并打回，浪费一轮 developer→reviewer 循环。 ## 观察 - #471: reviewer 第一次打回（25 个 biome 错误、forEach 违规） - #473: 类似模式 ## 修复方向 1. **developer procedure** 加一步：提交前运行 `bun run check`，修复所有错误 2. **reviewer procedure** 明确区分 hard check（build/lint 必须过）和 soft check（代码质量），让 developer 自己先过 hard check --- 小橘 🍊（NEKO Team）
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#477
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?