uncaged/workflow
Archived
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

bug: config list 未 mask apiKey（#530 重构遗漏） #531

New Issue
Closed
opened 2026-05-26 05:44:36 +00:00 by xiaomo · 0 comments
xiaomo commented 2026-05-26 05:44:36 +00:00
Owner
Copy Link
Copy Source

Problem

#530 将 apiKeyEnv 重命名为 apiKey，但 maskApiKeys() 函数（packages/cli-workflow/src/commands/config.ts:116）仍在检查 apiKeyEnv，导致 uwf config list 会泄露完整 API key。

对应的测试文件 config.test.ts 也仍引用 apiKeyEnv，所以测试也没覆盖到这个回归。

Reproduction

uwf config list
# providers.dashscope.apiKey 显示完整 key，未被 mask

Fix

  1. config.ts:116 — "apiKeyEnv" in providerObj → "apiKey" in providerObj
  2. config.ts:117 — providerObj.apiKeyEnv = "***MASKED***" → providerObj.apiKey = "***MASKED***"
  3. 更新 config.test.ts 中所有 apiKeyEnv 引用为 apiKey

Additional

另外发现 uwf config set 对 unknown key 不做校验，直接写入 config.yaml。主人要求 unknown key 应报错。如果这是独立 issue 可以拆出去。

## Problem #530 将 `apiKeyEnv` 重命名为 `apiKey`，但 `maskApiKeys()` 函数（`packages/cli-workflow/src/commands/config.ts:116`）仍在检查 `apiKeyEnv`，导致 `uwf config list` 会**泄露完整 API key**。 对应的测试文件 `config.test.ts` 也仍引用 `apiKeyEnv`，所以测试也没覆盖到这个回归。 ## Reproduction ```bash uwf config list # providers.dashscope.apiKey 显示完整 key，未被 mask ``` ## Fix 1. `config.ts:116` — `"apiKeyEnv" in providerObj` → `"apiKey" in providerObj` 2. `config.ts:117` — `providerObj.apiKeyEnv = "***MASKED***"` → `providerObj.apiKey = "***MASKED***"` 3. 更新 `config.test.ts` 中所有 `apiKeyEnv` 引用为 `apiKey` ## Additional 另外发现 `uwf config set` 对 unknown key 不做校验，直接写入 config.yaml。主人要求 unknown key 应报错。如果这是独立 issue 可以拆出去。
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?