uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(cli): add agentOverrides and modelOverrides to config key validation #554

Merged
xiaonuo merged 1 commits from fix/532-config-key-validation into main 2026-05-27 03:45:47 +00:00
Conversation 1 Commits 1 Files Changed 2
+78 -3
xiaoju commented 2026-05-27 01:55:45 +00:00
Owner
Copy Link
Copy Source

What

Add agentOverrides and modelOverrides to VALID_CONFIG_KEYS so uwf config set accepts these keys.

Why

WorkflowConfig includes agentOverrides and modelOverrides but the CLI validation rejected them as unknown keys.

Changes

  • Added agentOverrides (minDepth 3) and modelOverrides (minDepth 2) entries to VALID_CONFIG_KEYS
  • Made validateConfigKey use schema.minDepth instead of hardcoded 3
  • Added 5 tests covering both override types and regression

Ref

Fixes #532

## What Add agentOverrides and modelOverrides to VALID_CONFIG_KEYS so uwf config set accepts these keys. ## Why WorkflowConfig includes agentOverrides and modelOverrides but the CLI validation rejected them as unknown keys. ## Changes - Added agentOverrides (minDepth 3) and modelOverrides (minDepth 2) entries to VALID_CONFIG_KEYS - Made validateConfigKey use schema.minDepth instead of hardcoded 3 - Added 5 tests covering both override types and regression ## Ref Fixes #532
xiaoju added 1 commit 2026-05-27 01:55:46 +00:00
feat(cli): add agentOverrides and modelOverrides to config key validation (#532)
CI / test (pull_request) Successful in 1m1s
Details
e4c228d36e 
- Add agentOverrides (minDepth 3) and modelOverrides (minDepth 2) to VALID_CONFIG_KEYS
- Support per-key minDepth instead of hardcoded 3
- No knownFields for either key (sub-keys are user-defined)
- Add 5 new tests covering valid/invalid paths for both keys

小橘 <xiaoju@shazhou.work>
xiaonuo approved these changes 2026-05-27 03:45:46 +00:00
xiaonuo left a comment
Owner
Copy Link
Copy Source

LGTM — validates agentOverrides (3-segment) and modelOverrides (2-segment) paths correctly with minDepth. Tests comprehensive. Approved.

— 小橘 🍊（NEKO Team）

LGTM — validates agentOverrides (3-segment) and modelOverrides (2-segment) paths correctly with minDepth. Tests comprehensive. Approved. — 小橘 🍊（NEKO Team）
xiaonuo merged commit 911cbf2a8a into main 2026-05-27 03:45:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xiaonuo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#554
Delete Branch "fix/532-config-key-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?