uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

improve(workflow): fix committer tea PR creation in worktrees #578

Closed
xingyue wants to merge 0 commits from retrospect/fix-committer-tea into main
pull from: retrospect/fix-committer-tea
merge into: uncaged:main
Conversation 0 Commits - Files Changed -
+6 -4
xingyue commented 2026-05-30 07:43:24 +00:00
Owner
Copy Link
Copy Source

What

Fix committer role procedure in solve-issue workflow to handle worktree environments correctly.

Why

Thread 06F7EYMQN02KBCVRD522BD2V48 revealed two issues:

  1. tea pr create --repo fails in worktrees (tea does not recognize .git pointer files) — caused 6 blind retries
  2. Committer unconditionally re-stages already-committed changes — wasted 3 turns

Findings

  • Finding 1 (Medium): tea v0.14.1 requires CWD to be a real git dir, not a worktree
  • Finding 2 (Low): Developer already commits; staging is redundant

Changes

  • Step 4: Remove --repo flag, cd to main repo root before tea pr create
  • Steps 1-2: Add git status guard to skip staging if tree is clean and ahead of origin
## What Fix committer role procedure in solve-issue workflow to handle worktree environments correctly. ## Why Thread 06F7EYMQN02KBCVRD522BD2V48 revealed two issues: 1. `tea pr create --repo` fails in worktrees (tea does not recognize .git pointer files) — caused 6 blind retries 2. Committer unconditionally re-stages already-committed changes — wasted 3 turns ## Findings - Finding 1 (Medium): tea v0.14.1 requires CWD to be a real git dir, not a worktree - Finding 2 (Low): Developer already commits; staging is redundant ## Changes - Step 4: Remove `--repo` flag, cd to main repo root before `tea pr create` - Steps 1-2: Add `git status` guard to skip staging if tree is clean and ahead of origin
xingyue added 1 commit 2026-05-30 07:43:25 +00:00
improve(workflow): solve-issue — fix committer tea PR creation in worktrees
CI / check (pull_request) Successful in 1m20s
Details
0fcab06b80 
- Remove --repo flag from tea pr create (fails in git worktrees)
- Add guard to skip staging when developer already committed changes

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
xingyue closed this pull request 2026-05-30 07:45:23 +00:00
Some checks are pending
CI / check (pull_request) Successful in 1m20s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#578
Delete Branch "retrospect/fix-committer-tea"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?