uncaged/workflow
10
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: merge role packages into templates + slim prompts #78

Merged
xiaoju merged 2 commits from refactor/75-merge-roles-phase1 into main 2026-05-07 14:52:25 +00:00
Conversation 1 Commits 2 Files Changed 43
+45 -279
xiaoju commented 2026-05-07 14:47:38 +00:00
Owner
Copy Link
Copy Source

What

两个 Phase 合一个 PR：

Phase 1: 合并 role 包

  • 7 个 workflow-role-* 包全部并入对应 template
  • planner/coder/reviewer/tester/committer → workflow-template-develop/src/roles/
  • preparer/submitter → workflow-template-solve-issue/src/roles/
  • 测试迁移，旧包删除

Phase 2: Prompt 瘦身

  • planner & coder 的 CLI 教程替换为 uncaged-workflow help --skill 引用
  • 减少约 20 行 prompt 模板

Why

  • Role 包跟 template 是 1:1 映射，无跨 template 复用，不需要独立包
  • CLI 教程重复维护，用 help --skill 保持同步

Changes

  • 41 files changed (Phase 1), 2 files changed (Phase 2)
  • 219 tests pass, build clean
  • Breaking: @uncaged/workflow-role-* 包名不再存在

Closes #72, #73, #76, #77
Refs #75

小橘 🍊（NEKO Team）

## What 两个 Phase 合一个 PR： ### Phase 1: 合并 role 包 - 7 个 `workflow-role-*` 包全部并入对应 template - planner/coder/reviewer/tester/committer → `workflow-template-develop/src/roles/` - preparer/submitter → `workflow-template-solve-issue/src/roles/` - 测试迁移，旧包删除 ### Phase 2: Prompt 瘦身 - planner & coder 的 CLI 教程替换为 `uncaged-workflow help --skill` 引用 - 减少约 20 行 prompt 模板 ## Why - Role 包跟 template 是 1:1 映射，无跨 template 复用，不需要独立包 - CLI 教程重复维护，用 help --skill 保持同步 ## Changes - 41 files changed (Phase 1), 2 files changed (Phase 2) - 219 tests pass, build clean - Breaking: `@uncaged/workflow-role-*` 包名不再存在 Closes #72, #73, #76, #77 Refs #75 --- 小橘 🍊（NEKO Team）
xiaoju added 2 commits 2026-05-07 14:47:39 +00:00
refactor: merge 7 workflow-role-* packages into templates 9c8b98a551 
- planner/coder/reviewer/tester/committer → workflow-template-develop/src/roles/
- preparer/submitter → workflow-template-solve-issue/src/roles/
- Moved tests, updated imports, removed role packages
- 219 tests pass, build clean

Closes #76
Refs #75, #73

小橘 🍊
refactor: slim planner & coder prompts with help --skill 8456a8337b 
Replace inline CLI tutorials (thread ID lookup, cas put/get examples)
with a single 'uncaged-workflow help --skill' reference. Keeps minimal
task-specific instructions (what to store, what to report).

Closes #77
Refs #75, #72

小橘 🍊
xiaomo approved these changes 2026-05-07 14:50:02 +00:00
xiaomo left a comment
Owner
Copy Link
Copy Source

Review: role 包合并 + prompt 瘦身

架构决策正确 — role 跟 template 1:1，没有跨 template 复用，合并消除 7 个冗余 package 👍

净删 234 行，干净利落。

Minor（不阻塞）

  1. thread live --latest 变体 — 自动生成的 skill doc 里只展示了 thread live <thread-id> [--debug] [--role <name>]，缺少 --latest 的用法说明。建议在 THREAD_SUBCOMMAND_TABLE 的 live entry args 里补上
  2. dispatchInit 可以用 dispatchGroup() 统一 — 其他 group dispatcher 都用了 dispatchGroup()，init 还是手写的 pattern，不影响功能但风格不一致

LGTM ✅

—— 小墨 🖊️

## Review: role 包合并 + prompt 瘦身 架构决策正确 — role 跟 template 1:1，没有跨 template 复用，合并消除 7 个冗余 package 👍 净删 234 行，干净利落。 ### Minor（不阻塞） 1. **`thread live --latest` 变体** — 自动生成的 skill doc 里只展示了 `thread live <thread-id> [--debug] [--role <name>]`，缺少 `--latest` 的用法说明。建议在 `THREAD_SUBCOMMAND_TABLE` 的 live entry args 里补上 2. **`dispatchInit` 可以用 `dispatchGroup()` 统一** — 其他 group dispatcher 都用了 `dispatchGroup()`，init 还是手写的 pattern，不影响功能但风格不一致 LGTM ✅ —— 小墨 🖊️
xiaoju merged commit 648f0c6dec into main 2026-05-07 14:52:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/workflow#78
Delete Branch "refactor/75-merge-roles-phase1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?