From 18e201b49c0b7ec8bbad46f9b81490cb5dd69d4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B0=8F=E6=A9=98?= Date: Tue, 28 Apr 2026 14:13:33 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20reviewer=20prompt=20=E2=80=94=20reject?= =?UTF-8?q?=20or=20approve,=20no=20middle=20ground?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../roles/reviewer/prompt.ts | 18 +++++++----------- .../sense-generator/roles/reviewer/prompt.ts | 18 +++++++----------- .../roles/reviewer/prompt.ts | 18 +++++++----------- 3 files changed, 21 insertions(+), 33 deletions(-) diff --git a/workflows/gitea-issue-solver/roles/reviewer/prompt.ts b/workflows/gitea-issue-solver/roles/reviewer/prompt.ts index 6532961..f12f61a 100644 --- a/workflows/gitea-issue-solver/roles/reviewer/prompt.ts +++ b/workflows/gitea-issue-solver/roles/reviewer/prompt.ts @@ -15,21 +15,17 @@ Run these commands and analyze the output: ## Checklist -### 🔴 Must reject (approved: false) +### 🔴 Reject (approved: false) — tell coder exactly what to fix - **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed - **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff - **Unrelated changes**: files modified outside the scope of the planner's design +- **Debug code**: console.log, debugger statements, TODO/FIXME without context +- **Hardcoded paths** that should be configurable +- **Missing files** from the planner's design +- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing -### ⚠️ Flag but may still approve -- Debug code left behind (console.log, debugger, TODO/FIXME without context) -- Hardcoded paths that should be configurable -- Missing type exports that other files might need - -### ✅ Verify -- All files from the planner's design are created/modified -- Code follows existing patterns (compare with sibling workflows) -- Meta types are simple routing signals (single boolean per role) -- No dynamic import() +### ✅ Approve (approved: true) — no comment needed +If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen. ## Output diff --git a/workflows/sense-generator/roles/reviewer/prompt.ts b/workflows/sense-generator/roles/reviewer/prompt.ts index 6532961..f12f61a 100644 --- a/workflows/sense-generator/roles/reviewer/prompt.ts +++ b/workflows/sense-generator/roles/reviewer/prompt.ts @@ -15,21 +15,17 @@ Run these commands and analyze the output: ## Checklist -### 🔴 Must reject (approved: false) +### 🔴 Reject (approved: false) — tell coder exactly what to fix - **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed - **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff - **Unrelated changes**: files modified outside the scope of the planner's design +- **Debug code**: console.log, debugger statements, TODO/FIXME without context +- **Hardcoded paths** that should be configurable +- **Missing files** from the planner's design +- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing -### ⚠️ Flag but may still approve -- Debug code left behind (console.log, debugger, TODO/FIXME without context) -- Hardcoded paths that should be configurable -- Missing type exports that other files might need - -### ✅ Verify -- All files from the planner's design are created/modified -- Code follows existing patterns (compare with sibling workflows) -- Meta types are simple routing signals (single boolean per role) -- No dynamic import() +### ✅ Approve (approved: true) — no comment needed +If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen. ## Output diff --git a/workflows/workflow-generator/roles/reviewer/prompt.ts b/workflows/workflow-generator/roles/reviewer/prompt.ts index 6532961..f12f61a 100644 --- a/workflows/workflow-generator/roles/reviewer/prompt.ts +++ b/workflows/workflow-generator/roles/reviewer/prompt.ts @@ -15,21 +15,17 @@ Run these commands and analyze the output: ## Checklist -### 🔴 Must reject (approved: false) +### 🔴 Reject (approved: false) — tell coder exactly what to fix - **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed - **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff - **Unrelated changes**: files modified outside the scope of the planner's design +- **Debug code**: console.log, debugger statements, TODO/FIXME without context +- **Hardcoded paths** that should be configurable +- **Missing files** from the planner's design +- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing -### ⚠️ Flag but may still approve -- Debug code left behind (console.log, debugger, TODO/FIXME without context) -- Hardcoded paths that should be configurable -- Missing type exports that other files might need - -### ✅ Verify -- All files from the planner's design are created/modified -- Code follows existing patterns (compare with sibling workflows) -- Meta types are simple routing signals (single boolean per role) -- No dynamic import() +### ✅ Approve (approved: true) — no comment needed +If everything looks clean, just approve. Do not add suggestions or warnings — they won't be seen. ## Output