fix: reviewer — remove 'missing files from planner' check, planner designs roles not files
This commit is contained in:
parent
18e201b49c
commit
76760c4d29
@ -18,10 +18,9 @@ Run these commands and analyze the output:
|
|||||||
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the task
|
||||||
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
- **Hardcoded paths** that should be configurable
|
- **Hardcoded paths** that should be configurable
|
||||||
- **Missing files** from the planner's design
|
|
||||||
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ✅ Approve (approved: true) — no comment needed
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
|
|||||||
@ -18,10 +18,9 @@ Run these commands and analyze the output:
|
|||||||
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the task
|
||||||
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
- **Hardcoded paths** that should be configurable
|
- **Hardcoded paths** that should be configurable
|
||||||
- **Missing files** from the planner's design
|
|
||||||
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ✅ Approve (approved: true) — no comment needed
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
|
|||||||
@ -18,10 +18,9 @@ Run these commands and analyze the output:
|
|||||||
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
### 🔴 Reject (approved: false) — tell coder exactly what to fix
|
||||||
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
||||||
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
||||||
- **Unrelated changes**: files modified outside the scope of the planner's design
|
- **Unrelated changes**: files modified outside the scope of the task
|
||||||
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
- **Debug code**: console.log, debugger statements, TODO/FIXME without context
|
||||||
- **Hardcoded paths** that should be configurable
|
- **Hardcoded paths** that should be configurable
|
||||||
- **Missing files** from the planner's design
|
|
||||||
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
- **Wrong patterns**: dynamic import(), interfaces instead of types, broken routing
|
||||||
|
|
||||||
### ✅ Approve (approved: true) — no comment needed
|
### ✅ Approve (approved: true) — no comment needed
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user