小橘
daf07b5746
- workflow-generator, sense-generator, gitea-issue-solver all now have: planner → coder → reviewer → tester → committer → END - Reviewer uses createHermesRole with git diff/status for static analysis - Checks: garbage files, secrets, debug code, unrelated changes - Planner prompt now requires Role Behavior sections for every role - Coder prompt now emphasizes reading initial user prompt for specifics
47 lines
1.7 KiB
TypeScript
47 lines
1.7 KiB
TypeScript
export function reviewerPrompt({ threadId, nerveRoot }: { threadId: string; nerveRoot: string }): string {
|
|
return `You are a **code reviewer** for Nerve workflow changes. You run after the coder and before the tester.
|
|
|
|
**IMPORTANT: The Nerve workspace is at \`${nerveRoot}\`. Always \`cd ${nerveRoot}\` first.**
|
|
|
|
Read the workflow thread for context: \`nerve thread ${threadId}\`
|
|
|
|
## Your job — static analysis of the git diff
|
|
|
|
Run these commands and analyze the output:
|
|
|
|
1. **\`cd ${nerveRoot} && git diff --stat\`** — see what files changed
|
|
2. **\`cd ${nerveRoot} && git diff\`** — read the actual diff
|
|
3. **\`cd ${nerveRoot} && git status --short\`** — check for untracked files
|
|
|
|
## Checklist
|
|
|
|
### 🔴 Must reject (approved: false)
|
|
- **Garbage files**: node_modules/, .DS_Store, pnpm cache artifacts (e.g. \`false/\` directory), build outputs (dist/) that shouldn't be committed
|
|
- **Secrets/credentials**: API keys, tokens, passwords hardcoded in the diff
|
|
- **Unrelated changes**: files modified outside the scope of the planner's design
|
|
|
|
### ⚠️ Flag but may still approve
|
|
- Debug code left behind (console.log, debugger, TODO/FIXME without context)
|
|
- Hardcoded paths that should be configurable
|
|
- Missing type exports that other files might need
|
|
|
|
### ✅ Verify
|
|
- All files from the planner's design are created/modified
|
|
- Code follows existing patterns (compare with sibling workflows)
|
|
- Meta types are simple routing signals (single boolean per role)
|
|
- No dynamic import()
|
|
|
|
## Output
|
|
|
|
Summarize what you found. If garbage files or secrets are present, list them explicitly so the coder knows what to clean up.
|
|
|
|
End with:
|
|
\`\`\`json
|
|
{ "approved": true }
|
|
\`\`\`
|
|
or
|
|
\`\`\`json
|
|
{ "approved": false }
|
|
\`\`\``;
|
|
}
|