shazhou/united-workforce
8
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: move hooks before early returns to fix Rules of Hooks crash

Browse Source
This commit is contained in:
星月
2026-05-14 16:53:47 +08:00
parent c7b426ff5a
commit b9d543a465
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/workflow-dashboard/src/components/workflow-list.tsx
+16 -16
View File
@@ -109,6 +109,21 @@ function ExpandedWorkflowBody({
const [highlightedRole, setHighlightedRole] = useState<string | null>(null); const [highlightedRole, setHighlightedRole] = useState<string | null>(null);
const highlightTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null); const highlightTimerRef = useRef<ReturnType<typeof setTimeout> | null>(null);
const detail = cacheEntry?.status === "ok" ? cacheEntry.detail : null;
const descriptor = detail?.descriptor ?? null;
const roleEntries = descriptor !== null ? Object.entries(descriptor.roles) : [];
// All roles are "completed" (static view, all nodes lit) — must be before early returns
const allLitStates = useMemo(() => {
const m = new Map<string, NodeState>();
m.set("__start__", "completed");
m.set("__end__", "completed");
for (const [name] of roleEntries) {
m.set(name, "completed");
}
return m;
}, [roleEntries]);
if (cacheEntry === undefined || cacheEntry.status === "loading") { if (cacheEntry === undefined || cacheEntry.status === "loading") {
return ( return (
<p className="text-sm py-2" style={{ color: "var(--color-text-muted)" }}> <p className="text-sm py-2" style={{ color: "var(--color-text-muted)" }}>
@@ -125,14 +140,10 @@ function ExpandedWorkflowBody({
); );
} }
const { detail } = cacheEntry;
const descriptor = detail.descriptor;
const edgeCount = descriptor !== null ? descriptor.graph.edges.length : 0; const edgeCount = descriptor !== null ? descriptor.graph.edges.length : 0;
const vc = versionCount(detail); const vc = detail !== null ? versionCount(detail) : 0;
const hasGraph = descriptor !== null && edgeCount > 0; const hasGraph = descriptor !== null && edgeCount > 0;
const roleEntries =
descriptor !== null ? Object.entries(descriptor.roles) : [];
function handleGraphNodeClick(nodeId: string) { function handleGraphNodeClick(nodeId: string) {
const el = document.getElementById(`role-${nodeId}`); const el = document.getElementById(`role-${nodeId}`);
@@ -146,17 +157,6 @@ function ExpandedWorkflowBody({
}, 1500); }, 1500);
} }
// All roles are "completed" (static view, all nodes lit)
const allLitStates = useMemo(() => {
const m = new Map<string, NodeState>();
m.set("__start__", "completed");
m.set("__end__", "completed");
for (const [name] of roleEntries) {
m.set(name, "completed");
}
return m;
}, [roleEntries]);
return ( return (
<div className="pt-3 border-t flex gap-4" style={{ borderColor: "var(--color-border)" }}> <div className="pt-3 border-t flex gap-4" style={{ borderColor: "var(--color-border)" }}>
{/* Left: graph sidebar */} {/* Left: graph sidebar */}