Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| aaadab4445 |
@@ -6,6 +6,7 @@ import {
|
|||||||
type AgentContext,
|
type AgentContext,
|
||||||
type AgentRunResult,
|
type AgentRunResult,
|
||||||
buildContinuationPrompt,
|
buildContinuationPrompt,
|
||||||
|
buildFrontmatterRetryPrompt,
|
||||||
buildRolePrompt,
|
buildRolePrompt,
|
||||||
buildThreadProgress,
|
buildThreadProgress,
|
||||||
createAgent,
|
createAgent,
|
||||||
@@ -189,13 +190,20 @@ async function runClaudeCode(ctx: AgentContext, model: string | null): Promise<A
|
|||||||
ctx.storageRoot,
|
ctx.storageRoot,
|
||||||
);
|
);
|
||||||
if (cachedSessionId !== null) {
|
if (cachedSessionId !== null) {
|
||||||
|
// isFirstVisit + cache hit = previous run completed but frontmatter
|
||||||
|
// validation failed. The session already has full context — send a
|
||||||
|
// minimal correction prompt instead of the full initial prompt.
|
||||||
|
const resumePrompt = ctx.isFirstVisit
|
||||||
|
? buildFrontmatterRetryPrompt(ctx.outputFormatInstruction)
|
||||||
|
: fullPrompt;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const { stdout, stderr, exitCode } = await spawnClaudeResume(
|
const { stdout, stderr, exitCode } = await spawnClaudeResume(
|
||||||
cachedSessionId,
|
cachedSessionId,
|
||||||
fullPrompt,
|
resumePrompt,
|
||||||
model,
|
model,
|
||||||
);
|
);
|
||||||
const result = await processClaudeOutput(stdout, stderr, exitCode, ctx.store, fullPrompt);
|
const result = await processClaudeOutput(stdout, stderr, exitCode, ctx.store, resumePrompt);
|
||||||
if (result.sessionId !== undefined && result.sessionId !== "") {
|
if (result.sessionId !== undefined && result.sessionId !== "") {
|
||||||
await setCachedSessionId(
|
await setCachedSessionId(
|
||||||
"claude-code",
|
"claude-code",
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import {
|
|||||||
type AgentContext,
|
type AgentContext,
|
||||||
type AgentRunResult,
|
type AgentRunResult,
|
||||||
buildContinuationPrompt,
|
buildContinuationPrompt,
|
||||||
|
buildFrontmatterRetryPrompt,
|
||||||
buildRolePrompt,
|
buildRolePrompt,
|
||||||
buildThreadProgress,
|
buildThreadProgress,
|
||||||
createAgent,
|
createAgent,
|
||||||
@@ -102,6 +103,8 @@ async function storePromptResult(store: Store, sessionId: string): Promise<{ det
|
|||||||
type PromptAttempt = {
|
type PromptAttempt = {
|
||||||
useContinuation: boolean;
|
useContinuation: boolean;
|
||||||
resumed: boolean;
|
resumed: boolean;
|
||||||
|
/** True when resuming after a frontmatter-only failure (isFirstVisit + cache hit). */
|
||||||
|
frontmatterRetry: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
async function prepareSession(
|
async function prepareSession(
|
||||||
@@ -112,7 +115,7 @@ async function prepareSession(
|
|||||||
): Promise<PromptAttempt> {
|
): Promise<PromptAttempt> {
|
||||||
if (resumeDisabled) {
|
if (resumeDisabled) {
|
||||||
await client.connect(cwd);
|
await client.connect(cwd);
|
||||||
return { useContinuation: false, resumed: false };
|
return { useContinuation: false, resumed: false, frontmatterRetry: false };
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check session cache regardless of isFirstVisit. A previous run may
|
// Check session cache regardless of isFirstVisit. A previous run may
|
||||||
@@ -123,19 +126,23 @@ async function prepareSession(
|
|||||||
if (cachedSessionId === null) {
|
if (cachedSessionId === null) {
|
||||||
log("6RWK3N8Q", `no cached session for ${ctx.threadId}:${ctx.role}, starting new session`);
|
log("6RWK3N8Q", `no cached session for ${ctx.threadId}:${ctx.role}, starting new session`);
|
||||||
await client.connect(cwd);
|
await client.connect(cwd);
|
||||||
return { useContinuation: false, resumed: false };
|
return { useContinuation: false, resumed: false, frontmatterRetry: false };
|
||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await client.resume(cachedSessionId, cwd);
|
await client.resume(cachedSessionId, cwd);
|
||||||
log("9MHT4V2P", `resumed hermes session ${cachedSessionId} for ${ctx.threadId}:${ctx.role}`);
|
log("9MHT4V2P", `resumed hermes session ${cachedSessionId} for ${ctx.threadId}:${ctx.role}`);
|
||||||
return { useContinuation: true, resumed: true };
|
return {
|
||||||
|
useContinuation: !ctx.isFirstVisit,
|
||||||
|
resumed: true,
|
||||||
|
frontmatterRetry: ctx.isFirstVisit,
|
||||||
|
};
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
const message = error instanceof Error ? error.message : String(error);
|
const message = error instanceof Error ? error.message : String(error);
|
||||||
log("3XPN7K4W", `session resume failed, falling back to new session: ${message}`);
|
log("3XPN7K4W", `session resume failed, falling back to new session: ${message}`);
|
||||||
await client.close();
|
await client.close();
|
||||||
await client.connect(cwd);
|
await client.connect(cwd);
|
||||||
return { useContinuation: false, resumed: false };
|
return { useContinuation: false, resumed: false, frontmatterRetry: false };
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -158,9 +165,12 @@ export function createHermesAgent(resumeDisabled: boolean): () => Promise<void>
|
|||||||
ctx: AgentContext,
|
ctx: AgentContext,
|
||||||
useContinuation: boolean,
|
useContinuation: boolean,
|
||||||
beforeTurns: TurnsSnapshot,
|
beforeTurns: TurnsSnapshot,
|
||||||
|
frontmatterRetry: boolean,
|
||||||
): Promise<AgentRunResult> {
|
): Promise<AgentRunResult> {
|
||||||
const effectiveCtx = useContinuation ? ctx : { ...ctx, isFirstVisit: true };
|
// Frontmatter retry: session has full context, just re-output the format.
|
||||||
const fullPrompt = buildHermesPrompt(effectiveCtx);
|
const fullPrompt = frontmatterRetry
|
||||||
|
? buildFrontmatterRetryPrompt(ctx.outputFormatInstruction)
|
||||||
|
: buildHermesPrompt(useContinuation ? ctx : { ...ctx, isFirstVisit: true });
|
||||||
const startMs = Date.now();
|
const startMs = Date.now();
|
||||||
const { text, sessionId, usage: acpUsage } = await client.prompt(fullPrompt);
|
const { text, sessionId, usage: acpUsage } = await client.prompt(fullPrompt);
|
||||||
const durationSec = (Date.now() - startMs) / 1000;
|
const durationSec = (Date.now() - startMs) / 1000;
|
||||||
@@ -192,7 +202,7 @@ export function createHermesAgent(resumeDisabled: boolean): () => Promise<void>
|
|||||||
const beforeTurns = snapshotTurns(beforeSession);
|
const beforeTurns = snapshotTurns(beforeSession);
|
||||||
|
|
||||||
try {
|
try {
|
||||||
return await runPrompt(ctx, attempt.useContinuation, beforeTurns);
|
return await runPrompt(ctx, attempt.useContinuation, beforeTurns, attempt.frontmatterRetry);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
if (!attempt.resumed) {
|
if (!attempt.resumed) {
|
||||||
throw error;
|
throw error;
|
||||||
@@ -203,7 +213,7 @@ export function createHermesAgent(resumeDisabled: boolean): () => Promise<void>
|
|||||||
await client.close();
|
await client.close();
|
||||||
await client.connect(cwd);
|
await client.connect(cwd);
|
||||||
// Fresh session after retry — reset snapshot to zero
|
// Fresh session after retry — reset snapshot to zero
|
||||||
return runPrompt(ctx, false, ZERO_TURNS);
|
return runPrompt(ctx, false, ZERO_TURNS, false);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,23 @@
|
|||||||
|
import { describe, expect, test } from "vitest";
|
||||||
|
import { buildFrontmatterRetryPrompt } from "../src/frontmatter-retry-prompt.js";
|
||||||
|
|
||||||
|
describe("buildFrontmatterRetryPrompt", () => {
|
||||||
|
test("includes correction instruction", () => {
|
||||||
|
const result = buildFrontmatterRetryPrompt("Use YAML frontmatter");
|
||||||
|
expect(result).toContain("previous run completed");
|
||||||
|
expect(result).toContain("do NOT need to redo any work");
|
||||||
|
expect(result).toContain("corrected YAML frontmatter");
|
||||||
|
});
|
||||||
|
|
||||||
|
test("includes outputFormatInstruction when provided", () => {
|
||||||
|
const instruction = "---\nstatus: $done | $review\nsummary: string\n---";
|
||||||
|
const result = buildFrontmatterRetryPrompt(instruction);
|
||||||
|
expect(result).toContain(instruction);
|
||||||
|
});
|
||||||
|
|
||||||
|
test("works with empty outputFormatInstruction", () => {
|
||||||
|
const result = buildFrontmatterRetryPrompt("");
|
||||||
|
expect(result).not.toContain("\n\n\n");
|
||||||
|
expect(result).toContain("corrected YAML frontmatter");
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,21 @@
|
|||||||
|
/**
|
||||||
|
* Build a minimal prompt for retrying frontmatter output on a resumed session.
|
||||||
|
*
|
||||||
|
* Used when a previous run completed successfully but frontmatter validation
|
||||||
|
* failed — the session already has full context, we just need the agent to
|
||||||
|
* re-output correctly formatted frontmatter without redoing any work.
|
||||||
|
*/
|
||||||
|
export function buildFrontmatterRetryPrompt(outputFormatInstruction: string): string {
|
||||||
|
const parts: string[] = [
|
||||||
|
"Your previous run completed all work successfully, but the output format was incorrect.",
|
||||||
|
"You do NOT need to redo any work — all changes are already in place.",
|
||||||
|
"",
|
||||||
|
];
|
||||||
|
if (outputFormatInstruction !== "") {
|
||||||
|
parts.push(outputFormatInstruction, "");
|
||||||
|
}
|
||||||
|
parts.push(
|
||||||
|
"Please output ONLY the corrected YAML frontmatter block (--- delimited) followed by a brief summary of the work you completed.",
|
||||||
|
);
|
||||||
|
return parts.join("\n");
|
||||||
|
}
|
||||||
@@ -12,6 +12,7 @@ export {
|
|||||||
} from "./extract.js";
|
} from "./extract.js";
|
||||||
export type { FrontmatterFastPathResult } from "./frontmatter.js";
|
export type { FrontmatterFastPathResult } from "./frontmatter.js";
|
||||||
export { tryFrontmatterFastPath } from "./frontmatter.js";
|
export { tryFrontmatterFastPath } from "./frontmatter.js";
|
||||||
|
export { buildFrontmatterRetryPrompt } from "./frontmatter-retry-prompt.js";
|
||||||
export { createAgent, parseArgv } from "./run.js";
|
export { createAgent, parseArgv } from "./run.js";
|
||||||
export { getCachedSessionId, getCachePath, setCachedSessionId } from "./session-cache.js";
|
export { getCachedSessionId, getCachePath, setCachedSessionId } from "./session-cache.js";
|
||||||
export { getConfigPath, getEnvPath, loadWorkflowConfig, resolveStorageRoot } from "./storage.js";
|
export { getConfigPath, getEnvPath, loadWorkflowConfig, resolveStorageRoot } from "./storage.js";
|
||||||
|
|||||||
Reference in New Issue
Block a user