shazhou/united-workforce
8
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore: remove integration tests, migrate to eval framework #60

New Issue
Closed
opened 2026-06-04 11:14:52 +00:00 by xiaoju · 0 comments
xiaoju commented 2026-06-04 11:14:52 +00:00
Owner
Copy Link
Copy Source

What

Delete packages/agent-hermes/__tests__/integration/ — these tests spawn a real hermes CLI and hit live LLM, belonging to the eval layer (#34), not CI.

Files to remove

  • acp-client.integration.test.ts (3 cases)
  • resume-e2e.integration.test.ts (1 case, already skipped)

Why

  • CI cannot run them (spawn hermes ENOENT)
  • ACP protocol parsing already covered by unit test acp-client.test.ts
  • Real agent interaction belongs in eval framework (#34)

Done when

  • integration/ directory deleted
  • CI passes without exclusion hacks
  • Eval framework (#34) covers connect/prompt/resume scenarios

小橘 🍊（NEKO Team）

## What Delete `packages/agent-hermes/__tests__/integration/` — these tests spawn a real hermes CLI and hit live LLM, belonging to the eval layer (#34), not CI. ## Files to remove - acp-client.integration.test.ts (3 cases) - resume-e2e.integration.test.ts (1 case, already skipped) ## Why - CI cannot run them (spawn hermes ENOENT) - ACP protocol parsing already covered by unit test acp-client.test.ts - Real agent interaction belongs in eval framework (#34) ## Done when - integration/ directory deleted - CI passes without exclusion hacks - Eval framework (#34) covers connect/prompt/resume scenarios 小橘 🍊（NEKO Team）
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shazhou/united-workforce#60
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?