shazhou/united-workforce
8
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: remove _ single-exit for user roles #88

Merged
xiaoju merged 1 commits from fix/86-remove-single-exit-underscore into main 2026-06-05 02:09:50 +00:00
Conversation 0 Commits 1 Files Changed 14
+158 -138
xiaoju commented 2026-06-05 02:04:26 +00:00
Owner
Copy Link
Copy Source

What

Remove the _ (single-exit / UNIT_STATUS) pattern for user-defined roles.

Why

_ makes frontmatter type indeterminate — user roles should always have explicit $status enum values. Breaking change for clearer workflow semantics.

Design

  • $START keeps _ — special entry node, no agent output
  • All user roles require explicit $status enum in frontmatter schema
  • Graph keys must match $status values — no wildcard fallback
  • Moderator errors on missing $status instead of silently using _

Changes

  • moderator/evaluate.ts — remove UNIT_STATUS fallback, error on missing $status
  • validate.ts — isGraph() rejects _ for non-$START roles
  • validate-semantic.ts — remove checkSingleExitRole(), require $status enum
  • 10 test files updated to use explicit status values
  • examples/analyze-topic.yaml — analyst role _ → done

Test

804/804 passed ✅

Fixes #86

## What Remove the `_` (single-exit / UNIT_STATUS) pattern for user-defined roles. ## Why `_` makes frontmatter type indeterminate — user roles should always have explicit `$status` enum values. Breaking change for clearer workflow semantics. ## Design - **$START keeps `_`** — special entry node, no agent output - **All user roles require explicit `$status` enum** in frontmatter schema - **Graph keys must match `$status` values** — no wildcard fallback - **Moderator errors on missing `$status`** instead of silently using `_` ## Changes - `moderator/evaluate.ts` — remove UNIT_STATUS fallback, error on missing $status - `validate.ts` — isGraph() rejects `_` for non-$START roles - `validate-semantic.ts` — remove checkSingleExitRole(), require $status enum - 10 test files updated to use explicit status values - `examples/analyze-topic.yaml` — analyst role `_` → `done` ## Test 804/804 passed ✅ Fixes #86
xiaoju added 1 commit 2026-06-05 02:04:27 +00:00
fix: remove _ single-exit for user roles
CI / check (pull_request) Successful in 3m7s
Details
63cb4d3645 
$START keeps _ (special entry node). All user-defined roles now require
explicit $status enum in frontmatter + matching graph keys.

- moderator: remove UNIT_STATUS fallback, error on missing $status
- validate: reject _ graph keys for non-$START roles
- validate-semantic: remove checkSingleExitRole(), require $status enum
- update all test fixtures to use explicit status values
- fix examples/analyze-topic.yaml

Fixes #86
xiaoju merged commit 3d8df5c8e2 into main 2026-06-05 02:09:50 +00:00
xiaoju deleted branch fix/86-remove-single-exit-underscore 2026-06-05 02:09:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shazhou/united-workforce#88
Delete Branch "fix/86-remove-single-exit-underscore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?