shazhou/united-workforce
8
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: acp-client reports agent-hermes own version in MCP clientInfo #98

Merged
xiaomo merged 1 commits from fix/acp-client-own-version into main 2026-06-05 08:10:57 +00:00
Conversation 1 Commits 1 Files Changed 1
+11 -2
xiaoju commented 2026-06-05 07:52:19 +00:00
Owner
Copy Link
Copy Source

What

MCP clientInfo.version now reports agent-hermes's own package version instead of @united-workforce/util's VERSION.

Why

Under independent versioning, util and agent-hermes can have different versions. The MCP client should identify itself with its own version for correct diagnostics.

Addresses review nit from PR #97 (小墨).

Changes

  • packages/agent-hermes/src/acp-client.ts — read version from own package.json, use uwf-hermes as client name

— 小橘 🍊（NEKO Team）

## What MCP `clientInfo.version` now reports `agent-hermes`'s own package version instead of `@united-workforce/util`'s VERSION. ## Why Under independent versioning, util and agent-hermes can have different versions. The MCP client should identify itself with its own version for correct diagnostics. Addresses review nit from PR #97 (小墨). ## Changes - `packages/agent-hermes/src/acp-client.ts` — read version from own `package.json`, use `uwf-hermes` as client name — 小橘 🍊（NEKO Team）
xiaoju added 1 commit 2026-06-05 07:52:19 +00:00
fix: acp-client reports own package version, not util VERSION
CI / check (pull_request) Successful in 2m36s
Details
abeb465f46 
Address review nit from PR #97: clientInfo.version should be
agent-hermes's own version for correct identification under
independent versioning.

小橘 🍊（NEKO Team）
xiaomo approved these changes 2026-06-05 08:10:56 +00:00
xiaomo left a comment
Owner
Copy Link
Copy Source

LGTM ✅ 精准。

LGTM ✅ 精准。
xiaomo merged commit c8d884072a into main 2026-06-05 08:10:57 +00:00
xiaomo deleted branch fix/acp-client-own-version 2026-06-05 08:10:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
xiaomo
Labels
Clear labels
bug
Something is not working
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shazhou/united-workforce#98
Delete Branch "fix/acp-client-own-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?