xiaoju
d90e29ad05
1. threads.yaml race condition: reload threads index after agent subprocess completes before updating head pointer (cli-uwf/commands/thread.ts) 2. evaluateJsonata not awaited: jsonata evaluate() returns Promise for async expressions — now properly awaited (uwf-moderator/evaluate.ts) 3. resolveWorkflowHash dead code: function always returns a value, removed impossible null return type and dead null-check branches at call sites (cli-uwf/store.ts, commands/thread.ts, commands/workflow.ts)
83 lines
2.1 KiB
TypeScript
83 lines
2.1 KiB
TypeScript
import type { ModeratorContext, WorkflowPayload } from "@uncaged/uwf-protocol";
|
|
import jsonata from "jsonata";
|
|
|
|
import type { Result } from "./types.js";
|
|
|
|
const START_ROLE = "$START";
|
|
|
|
function isTruthy(value: unknown): boolean {
|
|
if (value === null || value === undefined) {
|
|
return false;
|
|
}
|
|
if (typeof value === "boolean") {
|
|
return value;
|
|
}
|
|
if (typeof value === "number") {
|
|
return value !== 0 && !Number.isNaN(value);
|
|
}
|
|
if (typeof value === "string") {
|
|
return value.length > 0;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
async function evaluateJsonata(expression: string, context: ModeratorContext): Promise<Result<unknown, Error>> {
|
|
try {
|
|
const result = await jsonata(expression).evaluate(context);
|
|
return { ok: true, value: result };
|
|
} catch (error) {
|
|
return {
|
|
ok: false,
|
|
error: error instanceof Error ? error : new Error(String(error)),
|
|
};
|
|
}
|
|
}
|
|
|
|
function currentRole(context: ModeratorContext): string {
|
|
if (context.steps.length === 0) {
|
|
return START_ROLE;
|
|
}
|
|
return context.steps[context.steps.length - 1].role;
|
|
}
|
|
|
|
export async function evaluate(
|
|
workflow: WorkflowPayload,
|
|
context: ModeratorContext,
|
|
): Promise<Result<string, Error>> {
|
|
const role = currentRole(context);
|
|
const transitions = workflow.graph[role];
|
|
if (transitions === undefined) {
|
|
return {
|
|
ok: false,
|
|
error: new Error(`no transitions defined for role "${role}"`),
|
|
};
|
|
}
|
|
|
|
for (const transition of transitions) {
|
|
if (transition.condition === null) {
|
|
return { ok: true, value: transition.role };
|
|
}
|
|
|
|
const conditionDef = workflow.conditions[transition.condition];
|
|
if (conditionDef === undefined) {
|
|
return {
|
|
ok: false,
|
|
error: new Error(`unknown condition "${transition.condition}"`),
|
|
};
|
|
}
|
|
|
|
const evalResult = await evaluateJsonata(conditionDef.expression, context);
|
|
if (!evalResult.ok) {
|
|
return evalResult;
|
|
}
|
|
if (isTruthy(evalResult.value)) {
|
|
return { ok: true, value: transition.role };
|
|
}
|
|
}
|
|
|
|
return {
|
|
ok: false,
|
|
error: new Error(`no transition matched for role "${role}"`),
|
|
};
|
|
}
|