uncaged/json-cas
Archived
10
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: Phase 4 cleanup — dedupe types, remove unused params, fix tests #47

Merged
xiaoju merged 1 commits from fix/46-phase4-cleanup into main 2026-05-31 07:19:43 +00:00
Conversation 0 Commits 1 Files Changed 2
+16 -24
xiaoju commented 2026-05-31 07:19:41 +00:00
Owner
Copy Link
Copy Source

Post-merge cleanup from PR #45 review.

Fixes #46

小橘 🍊（NEKO Team）

Post-merge cleanup from PR #45 review. Fixes #46 --- 小橘 🍊（NEKO Team）
xiaoju added 1 commit 2026-05-31 07:19:41 +00:00
chore: Phase 4 cleanup — dedupe RenderOptions, remove unused param, fix test numbering 1e5f4b7c46 
1. Deduplicate RenderOptions type
   - Remove duplicate definition from liquid-render.ts
   - Import from render.ts instead (canonical location)

2. Remove unused _globalDecay parameter
   - Remove from renderNode function signature
   - Update all call sites

3. Fix test numbering gaps
   - Suite 4: Renumber 4.4→4.2, 4.5→4.3
   - Suite 7→6: Renumber 7.1→6.1, 7.2→6.2, 7.4→6.3
   - Suite 8→7: Renumber all 8.x→7.x tests
   - Suite 10→8: Renumber 10.1→8.1
   - Result: consecutive suite numbering (1-8)

4. CLI test status: All 95 tests pass (no pre-existing failures found)

Fixes #46

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xiaoju merged commit 4717024e9b into main 2026-05-31 07:19:43 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/json-cas#47
Delete Branch "fix/46-phase4-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?