Merge pull request 'chore: dead code cleanup — unused exports, stale docs, deprecated functions' (#304) from chore/dead-code-cleanup into main

packages/core/README.md

@@ -4,11 +4,11 @@ Shared types and configuration parser for the [nerve](../../README.md) observati
 
 ## What's Inside
 
-- **Type definitions** — `Signal`, `SenseConfig`, `SenseInfo`, `SenseReflexConfig`, `ReflexConfig` (sense-only), `WorkflowConfig`, `NerveConfig`, and related types
+- **Type definitions** — `Signal`, `SenseConfig`, `SenseInfo`, `WorkflowConfig`, `NerveConfig`, and related types
 - **Config parser** — `parseNerveConfig(yaml)` validates and parses `nerve.yaml` into `NerveConfig` (rejects reflex entries that declare a `workflow` key; reflexes only schedule senses)
-- **Sense → workflow routing** — `parseSenseWorkflowDirective`, `routeSenseComputeOutput`, and types `ParsedSenseWorkflowDirective`, `SenseComputeRoute`
+- **Sense → workflow routing** — `parseWorkflowTrigger`, `routeSenseComputeOutput`, and types `WorkflowTrigger`, `RoutedSenseOutput`
 - **Daemon IPC protocol** — request/response types (`DaemonIpcRequest`, `DaemonIpcResponse`, …) and `parseDaemonIpcRequest` for newline-delimited JSON on the CLI ↔ daemon socket
-- **Workflow automaton types** — `START` / `END` sentinel constants, `WorkflowMessage`, `StartStep`, `RoleStep`, `ModeratorContext` (`start` + `steps`; empty `steps` on first moderator call), `Moderator` (single `context` argument), `WorkflowDefinition`, `Role`, `SenseResult`, plus `DEFAULT_ENGINE_MAX_ROUNDS`
+- **Workflow automaton types** — `START` / `END` sentinel constants, `WorkflowMessage`, `StartStep`, `RoleStep`, `ModeratorContext` (`start` + `steps`; empty `steps` on first moderator call), `Moderator` (single `context` argument), `WorkflowDefinition`, `Role`, `RoleResult`, plus `DEFAULT_ENGINE_MAX_ROUNDS`
 - **Result type** — `Result<T>` with `ok()` / `err()` helpers for explicit error handling (no thrown exceptions for parse paths)
 
 ## Usage
@@ -26,23 +26,31 @@ if (result.ok) {
 ### Sense return → signal vs workflow
 
 ```typescript
-import { parseSenseWorkflowDirective, routeSenseComputeOutput } from "@uncaged/nerve-core";
+import { parseWorkflowTrigger, routeSenseComputeOutput } from "@uncaged/nerve-core";
 
-const directive = parseSenseWorkflowDirective("my-workflow|8|Hello from sense");
+const directive = parseWorkflowTrigger({
+  name: "my-workflow",
+  maxRounds: 8,
+  prompt: "Hello from sense",
+  dryRun: false,
+});
 if (directive.ok) {
-  console.log(directive.value.workflowName, directive.value.maxRounds, directive.value.prompt);
+  console.log(directive.value.name, directive.value.maxRounds, directive.value.prompt);
 }
 
 const route = routeSenseComputeOutput({
-  metric: 42,
-  workflow: "my-workflow|8|Run now",
+  signal: { metric: 42 },
+  workflow: {
+    name: "my-workflow",
+    maxRounds: 8,
+    prompt: "Run now",
+    dryRun: false,
+  },
 });
-if (route.kind === "launch") {
-  // engine starts workflow; no Signal to the bus for this return
-  console.log(route.launch);
-} else {
-  // normal signal with payload
-  console.log(route.payload);
+if (route.ok && route.value.workflow !== null) {
+  console.log(route.value.workflow);
+} else if (route.ok) {
+  console.log(route.value.signal);
 }
 ```
 

packages/core/src/agent.ts

@@ -21,9 +21,3 @@ export class ExtractError extends Error {
     Object.setPrototypeOf(this, new.target.prototype);
   }
 }
-
-/**
- * Agent adapter ids referenced by tooling / docs (RFC-003).
- * Workflows import adapter packages directly; echo may be used in tests via a small factory.
- */
-export const KNOWN_AGENT_ADAPTER_IDS = ["echo", "cursor", "hermes", "codex"] as const;

packages/core/src/index.ts

@@ -13,7 +13,7 @@ export type {
 } from "./config.js";
 export type { Signal, SenseInfo } from "./sense.js";
 export type { SenseComputeFn, SenseModule } from "./sense.js";
-export { labelSenseTrigger, senseTriggerLabels } from "./sense.js";
+export { senseTriggerLabels } from "./sense.js";
 export type {
   WorkflowMessage,
   RoleResult,
@@ -29,7 +29,6 @@ export type {
   WorkflowDefinition,
 } from "./workflow.js";
 export { START, END, DEFAULT_ENGINE_MAX_ROUNDS } from "./workflow.js";
-export { parseDurationStringToMs } from "./util.js";
 export type { Schema, ExtractFn } from "./agent.js";
 export { ExtractError } from "./agent.js";
 export type { Result } from "./util.js";
@@ -46,7 +45,6 @@ export { parseNerveConfig } from "./config.js";
 export type { KnowledgeConfig } from "./config.js";
 export { parseKnowledgeYaml } from "./config.js";
 export { isPlainRecord } from "./util.js";
-export { KNOWN_AGENT_ADAPTER_IDS } from "./agent.js";
 
 export type { RoutedSenseOutput } from "./sense.js";
 export { parseWorkflowTrigger, routeSenseComputeOutput } from "./sense.js";

packages/daemon/src/agent-adapters/echo.ts

@@ -1,9 +0,0 @@
-import type { AgentConfig, AgentFn, ThreadContext } from "@uncaged/nerve-core";
-
-/**
- * Echo adapter (`type: "echo"`) — returns the assembled prompt unchanged.
- * Used for tests and dry-run wiring before real adapters exist.
- */
-export function createEchoAgent(_config: AgentConfig): AgentFn {
-  return async (_ctx: ThreadContext, prompt: string) => prompt;
-}

packages/daemon/src/index.ts

@@ -56,5 +56,3 @@ export type {
 
 export { createWorkflowManager } from "./workflow-manager.js";
 export type { WorkflowManager } from "./workflow-manager.js";
-
-export { createEchoAgent } from "./agent-adapters/echo.js";

packages/workflow-utils/src/index.ts

@@ -26,13 +26,11 @@ export {
 } from "./role-decorators.js";
 export {
   nerveCommandEnv,
-  spawnSafe,
   type SpawnEnv,
   type SpawnError,
   type SpawnResult,
   type SpawnSafeOptions,
 } from "@uncaged/nerve-core";
 export type { LlmError, LlmProvider } from "./shared/llm-extract.js";
-export { isDryRun } from "./role-types.js";
 export type { LlmMessage, MetaExtractConfig } from "./role-types.js";
 export type { LlmChatError } from "./shared/llm-chat.js";

packages/workflow-utils/src/role-types.ts

@@ -1,16 +1,8 @@
-import type { SpawnEnv, StartStep, ThreadContext } from "@uncaged/nerve-core";
+import type { SpawnEnv, ThreadContext } from "@uncaged/nerve-core";
 import type { z } from "zod";
 
 import type { LlmProvider } from "./shared/llm-extract.js";
 
-/**
- * @deprecated `dryRun` has been removed from `StartStep.meta` (RFC-005).
- * Use adapter/role-level `dryRun` config instead.
- */
-export function isDryRun(_start: StartStep): boolean {
-  return false;
-}
-
 export type CliPromptFn = (ctx: ThreadContext) => Promise<string>;
 
 export type LlmMessage = { role: "system" | "user" | "assistant"; content: string };

packages/workflow-utils/src/shared/hermes-agent.ts

@@ -3,7 +3,7 @@ import type { HermesRoleDefaults, HermesRoleRequired } from "../role-types.js";
 export { hermesAgent } from "@uncaged/nerve-adapter-hermes";
 export type { HermesAgentOptions } from "@uncaged/nerve-adapter-hermes";
 
-// --- Hermes options resolution (absorbed from hermes-options.ts) ---
+// --- Hermes role defaults resolution ---
 
 const HERMES_DEFAULTS: HermesRoleDefaults = {
   model: null,