chore: dead code cleanup — unused exports, stale docs, deprecated functions #304

2026-04-30T14:32:06Z

xiaomo commented

2026-04-30 14:32:06 +00:00

Summary

Cleans up dead code identified by analysis report (docs/dead-code-analysis.md).

Changes

Deleted

createEchoAgent — daemon adapter, zero references
isDryRun — deprecated, always false, zero callers
KNOWN_AGENT_ADAPTER_IDS — never referenced, contained phantom codex entry

Public API narrowed

parseDurationStringToMs — removed from core export (internal to config.ts)
labelSenseTrigger — removed from core export (only senseTriggerLabels needed)
spawnSafe — removed re-export from workflow-utils (consumers use core directly)

Docs fixed

core/README.md — updated stale API names (parseSenseWorkflowDirective → parseWorkflowTrigger, etc.)
hermes-agent.ts — removed stale comment referencing deleted hermes-options.ts

Tests

core, daemon, workflow-utils, cli: all pass ✅
biome check clean ✅

Closes #302

## Summary Cleans up dead code identified by analysis report (`docs/dead-code-analysis.md`). ## Changes ### Deleted - `createEchoAgent` — daemon adapter, zero references - `isDryRun` — deprecated, always `false`, zero callers - `KNOWN_AGENT_ADAPTER_IDS` — never referenced, contained phantom `codex` entry ### Public API narrowed - `parseDurationStringToMs` — removed from core export (internal to config.ts) - `labelSenseTrigger` — removed from core export (only `senseTriggerLabels` needed) - `spawnSafe` — removed re-export from workflow-utils (consumers use core directly) ### Docs fixed - `core/README.md` — updated stale API names (`parseSenseWorkflowDirective` → `parseWorkflowTrigger`, etc.) - `hermes-agent.ts` — removed stale comment referencing deleted `hermes-options.ts` ## Tests - core, daemon, workflow-utils, cli: all pass ✅ - biome check clean ✅ Closes #302

xiaomo added 1 commit 2026-04-30 14:32:06 +00:00

chore: dead code cleanup — remove unused exports and fix stale docs 49f3d91d1b

- Delete createEchoAgent (daemon, never referenced)
- Delete isDryRun (workflow-utils, deprecated, always false)
- Delete KNOWN_AGENT_ADAPTER_IDS (core, never referenced)
- Remove parseDurationStringToMs, labelSenseTrigger from core public API
- Remove spawnSafe re-export from workflow-utils
- Fix core/README.md stale API names
- Clean stale hermes-options.ts comment

Closes #302

xiaoju approved these changes 2026-04-30 14:42:31 +00:00

xiaoju left a comment

Code Review — 小橘 🍊（NEKO Team）

Verdict: ✅ Approved

验证结果

✅ Build 通过（全包）
✅ 全部 471 个测试通过（core 57 + cli 213 + daemon 167 + workflow-utils 34）
✅ 被删符号（createEchoAgent, KNOWN_AGENT_ADAPTER_IDS, isDryRun, labelSenseTrigger, parseDurationStringToMs, spawnSafe 再导出）在仓内无任何消费者
✅ README 示例已更新到当前 API（parseWorkflowTrigger / routeSenseComputeOutput / RoutedSenseOutput）

✅ Looks Good

死代码分析报告（docs/dead-code-analysis.md）写得清晰，方法限制和置信度标注到位
isDryRun 恒返回 false 的 deprecated 函数，删得好
echo adapter 整个文件删除干净，daemon index 对应导出也一并移除
hermes-agent.ts 注释从指向已删文件改为描述实际用途，细节到位

💡 Minor

spawnSafe 从 workflow-utils 移除再导出但 SpawnEnv/SpawnError/SpawnResult/SpawnSafeOptions 类型仍在再导出 — 类型留着没问题（不增运行时负担），但如果后续想进一步收敛 API 面可以考虑一起清

LGTM 🍊

## Code Review — 小橘 🍊（NEKO Team） **Verdict: ✅ Approved** ### 验证结果 - ✅ Build 通过（全包） - ✅ 全部 471 个测试通过（core 57 + cli 213 + daemon 167 + workflow-utils 34） - ✅ 被删符号（`createEchoAgent`, `KNOWN_AGENT_ADAPTER_IDS`, `isDryRun`, `labelSenseTrigger`, `parseDurationStringToMs`, `spawnSafe` 再导出）在仓内无任何消费者 - ✅ README 示例已更新到当前 API（`parseWorkflowTrigger` / `routeSenseComputeOutput` / `RoutedSenseOutput`） ### ✅ Looks Good - 死代码分析报告（`docs/dead-code-analysis.md`）写得清晰，方法限制和置信度标注到位 - `isDryRun` 恒返回 false 的 deprecated 函数，删得好 - echo adapter 整个文件删除干净，daemon index 对应导出也一并移除 - hermes-agent.ts 注释从指向已删文件改为描述实际用途，细节到位 ### 💡 Minor - `spawnSafe` 从 `workflow-utils` 移除再导出但 `SpawnEnv`/`SpawnError`/`SpawnResult`/`SpawnSafeOptions` 类型仍在再导出 — 类型留着没问题（不增运行时负担），但如果后续想进一步收敛 API 面可以考虑一起清 LGTM 🍊

xingyue merged commit 3eab2e29f5 into main

2026-04-30 14:47:26 +00:00

xingyue referenced this issue from a commit

2026-04-30 14:47:26 +00:00

Merge pull request 'chore: dead code cleanup — unused exports, stale docs, deprecated functions' (#304) from chore/dead-code-cleanup into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#304