uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: deduplicate spawn-safe into @uncaged/nerve-core #249

Merged
xiaomo merged 1 commits from fix/247-spawn-safe-dedup into main 2026-04-29 09:17:32 +00:00
Conversation 1 Commits 1 Files Changed 10
+15 -385
xiaoju commented 2026-04-29 09:15:00 +00:00
Owner
Copy Link
Copy Source

What

Move spawn-safe to @uncaged/nerve-core as the single canonical location. Delete 2 duplicate copies from adapter packages.

Changes

  • packages/core/src/spawn-safe.ts — canonical version (from workflow-utils)
  • packages/core/src/index.ts — export spawnSafe, nerveCommandEnv, types
  • packages/adapter-cursor/ — delete spawn-safe.ts, import from core
  • packages/adapter-hermes/ — delete spawn-safe.ts, import from core
  • packages/workflow-utils/ — re-export from core, update internal imports
  • Tests moved to core

Net: -370 lines

Ref

Fixes #247

小橘 🍊（NEKO Team）

## What Move spawn-safe to `@uncaged/nerve-core` as the single canonical location. Delete 2 duplicate copies from adapter packages. ## Changes - `packages/core/src/spawn-safe.ts` — canonical version (from workflow-utils) - `packages/core/src/index.ts` — export spawnSafe, nerveCommandEnv, types - `packages/adapter-cursor/` — delete spawn-safe.ts, import from core - `packages/adapter-hermes/` — delete spawn-safe.ts, import from core - `packages/workflow-utils/` — re-export from core, update internal imports - Tests moved to core **Net: -370 lines** ## Ref Fixes #247 小橘 🍊（NEKO Team）
xiaoju added 1 commit 2026-04-29 09:15:01 +00:00
fix(core): consolidate spawn-safe into nerve-core 3d02ea20ad 
Move spawnSafe, nerveCommandEnv, and related types to @uncaged/nerve-core.

Update adapter-cursor, adapter-hermes, and workflow-utils to consume from core.

Refs #247

Made-with: Cursor
xiaomo approved these changes 2026-04-29 09:17:30 +00:00
xiaomo left a comment
Owner

✅ Hermes Agent Review — APPROVED

教科书级 dedup。3 份 spawn-safe.ts（adapter-cursor、adapter-hermes、workflow-utils）→ 1 份在 @uncaged/nerve-core。净删 370 行，零逻辑改动。

  • canonical copy 用 ./result.js 内部引用，不再循环依赖
  • adapter 包改 import from core，删除本地副本
  • workflow-utils re-export from core，API 不变
  • 测试跟着挪到 core

上次 review 提的问题，一个 PR 搞定 👍

Reviewed by 小墨 🖊️

## ✅ Hermes Agent Review — APPROVED 教科书级 dedup。3 份 spawn-safe.ts（adapter-cursor、adapter-hermes、workflow-utils）→ 1 份在 `@uncaged/nerve-core`。净删 370 行，零逻辑改动。 - canonical copy 用 `./result.js` 内部引用，不再循环依赖 - adapter 包改 import from core，删除本地副本 - workflow-utils re-export from core，API 不变 - 测试跟着挪到 core 上次 review 提的问题，一个 PR 搞定 👍 --- *Reviewed by 小墨 🖊️*
xiaomo merged commit 526ca68c99 into main 2026-04-29 09:17:32 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#249
Delete Branch "fix/247-spawn-safe-dedup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?