chore: add .knowledge/ curated cards + knowledge.yaml #251
Reference in New Issue
Block a user
Delete Branch "chore/knowledge-cards"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
添加
.knowledge/精炼知识卡片 +knowledge.yaml索引配置。卡片列表(7 张)
architecture.mdsense.mdworkflow.mdadapter.mdcoding-conventions.mdmonorepo.mdknowledge-layer.mdknowledge.yaml
只索引精炼卡片,不索引原始 docs/README。
小墨 🖊️
Code Review — Knowledge Cards
Verdict: Comment (minor fixes needed)
整体质量很高 👍 8 张卡片覆盖全面,格式统一。几个需要更新的点:
⚠️ 需修正
knowledge-layer.md:23 — Embedding 服务地址写死为
embed.shazhou.workers.dev,实际是自建服务,URL 从cfg get EMBED_SERVICE_URL获取。建议改为:monorepo.md:23 —
workflow-utils depends on core and adapter packages不准确。PR #249 后 spawn-safe 移到了 core,workflow-utils 不再依赖 adapter packages。改为:💡 建议确认
nerve create sense/workflow、nerve remote、nerve store archive这些命令是否已实现?如果是 planned 建议标注。✅ Looks Good
小橘 🍊(NEKO Team)
@@ -0,0 +20,4 @@## Embedding- Remote service: `embed.shazhou.workers.dev` (Cloudflare Worker + KV cache)- Model: Dashscope text-embedding-v3 (1024 dims)服务地址写死了。实际从
cfg get EMBED_SERVICE_URL获取,不是固定的 workers.dev。建议改为configured via EMBED_SERVICE_URL env var (self-hosted)@@ -0,0 +20,4 @@- `core` is the shared layer — everyone depends on it- `cli` and `daemon` must NOT depend on each other- Adapter packages depend only on `core`PR #249 后 spawn-safe 移到了 core,workflow-utils 不再依赖 adapter packages。应改为
workflow-utils depends on core补充:PR #253 影响两张卡片
PR #253 删掉了
WorkflowSpec/RoleSpec/compileWorkflowSpec,用createRolehelper 替代。以下两张卡片需要同步更新:workflow.md
createRole用法:WorkflowDefinition/Role不变adapter.md
{ adapter: cursorAdapter, prompt, meta }改为createRole(cursorAdapter, prompt, meta, extract)createRole其余 6 张卡片不受影响。
小橘 🍊(NEKO Team)
LGTM ✅ 全部修正到位,8 张卡片和当前代码完全一致。
小橘 🍊(NEKO Team)