feat(workflow-utils): add withDryRun role wrapper #255

2026-04-29T13:00:23Z

xiaoju commented

2026-04-29 13:00:23 +00:00

Extracts repeated dry-run skip + try/catch error handling into withDryRun(role, { label, dryRunMeta, failMeta }).

4 tests added, all passing.

Closes #254

Extracts repeated dry-run skip + try/catch error handling into `withDryRun(role, { label, dryRunMeta, failMeta })`. 4 tests added, all passing. Closes #254

xiaoju added 1 commit 2026-04-29 13:00:23 +00:00

feat(workflow-utils): add withDryRun role wrapper 4a4a03a2bc

Extracts repeated dry-run skip + try/catch error handling into a
reusable wrapper. Includes tests.

Closes #254

scottwei requested changes 2026-04-29 13:09:43 +00:00

packages/workflow-utils/src/with-dry-run.ts Outdated

						
				@@ -0,0 +8,4 @@

				  /** Meta returned when dry-run skips execution. */

				  dryRunMeta: M;

				  /** Meta returned when the inner role throws. */

				  failMeta: M;

scottwei commented

2026-04-29 13:09:35 +00:00

failMeta 应该不是 withDryRun 考虑的，或许应该是另外一个decorator。
或许我们是不是应该搞个 decorator chain, e.g.

decorateRole(role, [
  withDryRun(dryRunOpts),
  onFail(failOpts),
]);

failMeta 应该不是 withDryRun 考虑的，或许应该是另外一个decorator。或许我们是不是应该搞个 decorator chain, e.g. ``` decorateRole(role, [ withDryRun(dryRunOpts), onFail(failOpts), ]); ```

xiaoju referenced this issue from a commit

2026-04-29 13:23:44 +00:00

refactor(workflow-utils): split withDryRun into decorator chain

xiaoju added 1 commit 2026-04-29 13:23:44 +00:00

refactor(workflow-utils): split withDryRun into decorator chain c08e7f085d

- withDryRun(opts) — only handles dry-run skip
- onFail(opts) — only handles try/catch error wrapping
- decorateRole(role, [...]) — composes decorators left-to-right
- RoleDecorator<M> type for custom decorators

Addresses review feedback on #255

scottwei requested changes 2026-04-29 13:25:53 +00:00

docs/rfc-004-package-architecture.md Outdated

						
				@@ -0,0 +1,168 @@

				# RFC-004: Package Architecture — Shareable Workflows, Roles & Senses

scottwei commented

2026-04-29 13:25:40 +00:00

这个应该是另一个 PR 吧？

packages/workflow-utils/src/with-dry-run.ts Outdated

						
				@@ -0,0 +65,4 @@

				// onFail — catch errors and return a structured failure result

				// ---------------------------------------------------------------------------

				export type OnFailOptions<M> = {