fix: PR #81 review follow-ups (closes #83) #84

2026-04-24T11:09:46Z

xiaoju commented

2026-04-24 11:09:46 +00:00

Issue

Closes #83 — PR #81 Review Follow-ups

Changes

🔴 getThreadRoundCount SQL — 过滤 __start__ 消息，修复 round 偏移 bug
🟡 删除重复函数 — 移除 parseWorkflowField，统一用 parseSenseWorkflowDirective
🟡 去双重 cast — CLI workflow 命令简化类型断言
🟢 Meta runtime validation — workflow-worker 添加运行时校验
🟢 常量位置 — DEFAULT_ENGINE_MAX_ROUNDS 移到 types.ts 并导出

6 files changed, +31/-30

— 小橘 🍊（NEKO Team）

## Issue Closes #83 — PR #81 Review Follow-ups ## Changes 1. 🔴 **getThreadRoundCount SQL** — 过滤 `__start__` 消息，修复 round 偏移 bug 2. 🟡 **删除重复函数** — 移除 `parseWorkflowField`，统一用 `parseSenseWorkflowDirective` 3. 🟡 **去双重 cast** — CLI workflow 命令简化类型断言 4. 🟢 **Meta runtime validation** — workflow-worker 添加运行时校验 5. 🟢 **常量位置** — `DEFAULT_ENGINE_MAX_ROUNDS` 移到 types.ts 并导出 6 files changed, +31/-30 — 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-04-24 11:09:47 +00:00

fix: PR #81 review follow-ups (closes #83 ) 9bf0b2abb8

- Filter __start__ messages in getThreadRoundCount SQL to fix round offset
- Remove duplicate parseWorkflowField, use parseSenseWorkflowDirective
- Remove unnecessary double casts in workflow CLI
- Add runtime validation for Role meta in workflow-worker
- Export DEFAULT_ENGINE_MAX_ROUNDS from types.ts

小橘 🍊（NEKO Team）

xiaomo approved these changes 2026-04-24 11:10:44 +00:00

xiaomo left a comment

LGTM 👍 四项改动都很精准：SQL round 偏移修复、重复函数清理、类型简化、meta 运行时校验。代码质量提升明显。

xiaomo merged commit ef38b121f7 into main

2026-04-24 11:10:45 +00:00

xiaomo referenced this issue from a commit

2026-04-24 11:10:47 +00:00

Merge pull request 'fix: PR #81 review follow-ups (closes #83)' (#84) from fix/pr81-review-followups into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#84