xiaoju
|
9443406703
|
fix(daemon): address all 12 PR #10 review items
🔴 Critical:
1. parseWorkerMessage() in ipc.ts — validates worker→parent IPC messages
2. signalIdCounter moved inside createKernel closure
3. throttle deferred trigger — pending trigger fires after window ends
⚠️ Warnings:
4. worker respawn on crash with backoff
5. stop() awaits worker exit with SIGKILL fallback
6. signal-bus handler errors caught, no re-throw
7. removed unnecessary as SenseReflexConfig cast
8. config validates sense reflex has at least one trigger
💡 Suggestions:
9. signal ID documented as process-scoped (solved by #2)
10. +3 throttle-pending tests
11. +6 kernel unit tests (mock fork, message routing)
12. example imports verified correct
54 tests (was 45), all green. biome check passes.
小橘 🍊(NEKO Team)
|
2026-04-22 09:34:13 +00:00 |
|
xiaoju
|
d9355a6299
|
feat(daemon): Signal Bus, Reflex Scheduler & Kernel (Phase 3)
- signal-bus: in-memory pub/sub for Signal dispatch, sync broadcast,
subscriber error isolation
- reflex-scheduler: interval + event-driven triggers, throttle enforcement,
merge/coalesce (pending flag, no unbounded queue), workflow reflexes skipped
- kernel: orchestrator tying workers, signal bus, and scheduler together,
graceful shutdown
- examples/nerve.yaml: cpu-usage (10s), disk-usage (30s), system-health
(on: [cpu-usage, disk-usage])
- 20 new tests (45 total): signal bus (8) + reflex scheduler (12)
Closes #4
小橘 🍊(NEKO Team)
|
2026-04-22 08:56:38 +00:00 |
|