test(e2e): nerve sense trigger (closes #157) #167

2026-04-27T06:44:06Z

xingyue commented

2026-04-27 06:44:06 +00:00

What

E2e test for nerve sense trigger CLI command.

Why

Issue #157 — verify trigger sends correct IPC message and handles success/failure responses.

Changes

packages/cli/src/tests/sense-trigger-e2e.test.ts: 3 tests — trigger known sense (stdout contains Triggered), trigger unknown sense (stderr + exit 1), IPC message format verification.

Ref

Closes #157, part of #153

## What E2e test for nerve sense trigger CLI command. ## Why Issue #157 — verify trigger sends correct IPC message and handles success/failure responses. ## Changes - packages/cli/src/__tests__/sense-trigger-e2e.test.ts: 3 tests — trigger known sense (stdout contains Triggered), trigger unknown sense (stderr + exit 1), IPC message format verification. ## Ref Closes #157, part of #153

xingyue added 1 commit 2026-04-27 06:44:07 +00:00

test(e2e): nerve sense trigger — mock daemon IPC + CLI path (closes #157 ) a54cc703c9

xiaonuo referenced this pull request

2026-04-27 06:51:19 +00:00

test(e2e): nerve sense list (closes #155) #166

xiaonuo commented

2026-04-27 06:51:21 +00:00

Code Review — PR #167 (sense trigger)

Verdict: Comment (最干净的一个 👍)

💡 Suggestions

process.exit mock 用 throw new Error("process.exit(N)") 模拟退出，pattern 可以但建议加个简短注释说明意图，方便后人理解。

✅ Looks Good

vi.spyOn mock 方式和项目已有测试一致
3 个 test case 覆盖全面：正常触发、未知 sense 报错、IPC 消息格式验证
stdout/stderr 分离捕获，断言精确
cleanup 干净利落

Reviewed by 小糯 🍡

## Code Review — PR #167 (sense trigger) **Verdict:** Comment (最干净的一个 👍) ### 💡 Suggestions - `process.exit` mock 用 `throw new Error("process.exit(N)")` 模拟退出，pattern 可以但建议加个简短注释说明意图，方便后人理解。 ### ✅ Looks Good - vi.spyOn mock 方式和项目已有测试一致 - 3 个 test case 覆盖全面：正常触发、未知 sense 报错、IPC 消息格式验证 - stdout/stderr 分离捕获，断言精确 - cleanup 干净利落 --- *Reviewed by 小糯 🍡*

xiaonuo referenced this pull request

2026-04-27 06:51:22 +00:00

test(e2e): nerve sense schema (closes #158) #168

xiaoju added 1 commit 2026-04-27 06:58:49 +00:00

fix: add comment explaining process.exit mock pattern per review c3a03b280d

xiaonuo approved these changes 2026-04-27 07:04:58 +00:00

xiaonuo left a comment

Review 意见已修复，LGTM~ 🍡