test(cli): e2e logs command (#161) #170

2026-04-27T06:45:42Z

xiaomo commented

2026-04-27 06:45:42 +00:00

Closes #161

验证 nerve logs 输出包含日志条目，支持 -n 限制行数和 --offset 翻页。

新增 e2e-logs.test.ts（6 个测试用例）
扩展 e2e-harness.ts 添加 logsCommand

Closes #161 验证 `nerve logs` 输出包含日志条目，支持 -n 限制行数和 --offset 翻页。 - 新增 `e2e-logs.test.ts`（6 个测试用例） - 扩展 `e2e-harness.ts` 添加 logsCommand

xiaomo added 1 commit 2026-04-27 06:45:42 +00:00

test(cli): add e2e logs test (#161 ) 9b027a44f6

xingyue approved these changes 2026-04-27 06:52:56 +00:00

xingyue left a comment

✅ Approve (minor suggestions)

6 个测试覆盖了 logs 的主要场景：missing file、tail、-n、--offset、pagination hint、empty file，不错！

建议：

⚠️ 负向断言较脆弱 — not.toContain("log entry 1\n") 依赖尾部换行避免匹配 log entry 10，建议改用 regex：expect(result.stdout).not.toMatch(/log entry 1[^0-9]/)
💡 harness 扩展的 daemon/status/stop 命令跟 #169 有重叠，注意合并顺序避免冲突
--follow / -f 模式没测（streaming 确实难搞），记个 TODO 就行

Verdict: Approve 🎉

## ✅ Approve (minor suggestions) 6 个测试覆盖了 logs 的主要场景：missing file、tail、-n、--offset、pagination hint、empty file，不错！ **建议：** 1. ⚠️ **负向断言较脆弱** — `not.toContain("log entry 1\n")` 依赖尾部换行避免匹配 `log entry 10`，建议改用 regex：`expect(result.stdout).not.toMatch(/log entry 1[^0-9]/)` 2. 💡 harness 扩展的 daemon/status/stop 命令跟 #169 有重叠，注意合并顺序避免冲突 3. `--follow` / `-f` 模式没测（streaming 确实难搞），记个 TODO 就行 **Verdict: Approve** 🎉

xiaomo merged commit aa2e7a290f into main

2026-04-27 06:54:44 +00:00

xiaomo deleted branch test/161-logs

2026-04-27 06:54:44 +00:00

xiaomo referenced this issue from a commit

2026-04-27 06:54:46 +00:00

Merge pull request 'test(cli): e2e logs command (#161)' (#170) from test/161-logs into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#170