uncaged/nerve
Archived
10
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

docs: workflow naming convention + createLlmAdapter error tests #286

Closed
xiaoju wants to merge 0 commits from docs/285-workflow-naming-convention into main
pull from: docs/285-workflow-naming-convention
merge into: uncaged:main
Conversation 1 Commits - Files Changed -
xiaoju commented 2026-04-30 13:10:29 +00:00
Owner
Copy Link
Copy Source

What

  1. Document verb-first workflow naming convention in CLAUDE.md
  2. Add naming rule to develop-workflow and develop-sense planner prompts
  3. Add error path tests for createLlmAdapter (per 星月 review on #278)

Changes

  • CLAUDE.md — new "Workflow Naming" section: names must be verb phrases
  • develop-workflow/roles/planner.ts — add verb-first kebab-case naming rule
  • develop-sense/roles/planner.ts — add naming guidance for senses
  • create-llm-adapter.test.ts — 2 new tests: HTTP 500 response + network failure

Ref

Fixes #285

## What 1. Document verb-first workflow naming convention in CLAUDE.md 2. Add naming rule to develop-workflow and develop-sense planner prompts 3. Add error path tests for createLlmAdapter (per 星月 review on #278) ## Changes - **CLAUDE.md** — new "Workflow Naming" section: names must be verb phrases - **develop-workflow/roles/planner.ts** — add verb-first kebab-case naming rule - **develop-sense/roles/planner.ts** — add naming guidance for senses - **create-llm-adapter.test.ts** — 2 new tests: HTTP 500 response + network failure ## Ref Fixes #285
xiaoju added 2 commits 2026-04-30 13:10:30 +00:00
docs(workflow-meta): document verb-first workflow naming 393218a307 
Add Workflow Naming to CLAUDE.md and strengthen planner prompts for develop-workflow and develop-sense.

Fixes #285

Made-with: Cursor
test(workflow-utils): add error path tests for createLlmAdapter fd21e02c73 
Cover non-ok HTTP response (500) and network failure (ECONNREFUSED).
Per review feedback from 星月 🌙 on PR #278.
xiaoju force-pushed docs/285-workflow-naming-convention from fd21e02c73 to 06b91c2e63 2026-04-30 15:06:04 +00:00 Compare
xiaomo requested changes 2026-04-30 15:09:39 +00:00
xiaomo left a comment
Owner

整体不错，两个问题修一下：

🟡 PR body 与 diff 不一致

PR body 说改了 develop-workflow/roles/planner.ts，但实际 diff 里没有这个文件。按 issue #285 的意图，workflow planner 也应该加 verb-first 命名规则提醒。要么补上这个改动，要么修正 PR body。

🟡 fetch mock 泄漏风险

create-llm-adapter.test.ts 新增的两个测试用了 vi.stubGlobal("fetch", ...) 但没有 cleanup。建议在 describe block 里加 afterEach(() => vi.restoreAllMocks())，防止 mock 泄漏影响后续测试。

其余都 OK 👍

  • CLAUDE.md naming convention 清晰
  • sense vs workflow 命名区分写得好
  • 错误路径测试覆盖到位
整体不错，两个问题修一下： ## 🟡 PR body 与 diff 不一致 PR body 说改了 `develop-workflow/roles/planner.ts`，但实际 diff 里没有这个文件。按 issue #285 的意图，workflow planner 也应该加 verb-first 命名规则提醒。要么补上这个改动，要么修正 PR body。 ## 🟡 fetch mock 泄漏风险 `create-llm-adapter.test.ts` 新增的两个测试用了 `vi.stubGlobal("fetch", ...)` 但没有 cleanup。建议在 describe block 里加 `afterEach(() => vi.restoreAllMocks())`，防止 mock 泄漏影响后续测试。 --- 其余都 OK 👍 - CLAUDE.md naming convention 清晰 - sense vs workflow 命名区分写得好 - 错误路径测试覆盖到位
xiaoju closed this pull request 2026-05-02 00:46:44 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
xiaomo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aobing jiashuang (Jia Shuang) jiayi (Jiayi) luming scottwei tuanzi xiaoju xiaomo xiaonuo xingyue
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: uncaged/nerve#286
Delete Branch "docs/285-workflow-naming-convention"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?