refactor: add daemon subcommand group and dev foreground mode #54

2026-04-23T01:16:27Z

xiaoju commented

2026-04-23 01:16:27 +00:00

Summary

Implements #53 — restructure CLI into nerve daemon subcommand group.

Changes

nerve daemon subcommand group: start, stop, status, restart, logs
nerve dev for foreground mode (replaces old start without -d)
nerve daemon start is always background (removed -d/--daemon flag)
Top-level aliases preserved: nerve start/stop/status/logs → nerve daemon *
Extracted runStopCommand() for restart reuse
New daemon-cli test suite

Test Results

core: 21/21 ✅
daemon: 213/213 ✅
cli: 107/107 ✅

Closes #53

— 小橘 🍊（NEKO Team）

## Summary Implements #53 — restructure CLI into `nerve daemon` subcommand group. ### Changes - **`nerve daemon`** subcommand group: `start`, `stop`, `status`, `restart`, `logs` - **`nerve dev`** for foreground mode (replaces old `start` without `-d`) - `nerve daemon start` is always background (removed `-d/--daemon` flag) - Top-level aliases preserved: `nerve start/stop/status/logs` → `nerve daemon *` - Extracted `runStopCommand()` for `restart` reuse - New `daemon-cli` test suite ### Test Results - core: 21/21 ✅ - daemon: 213/213 ✅ - cli: 107/107 ✅ Closes #53 — 小橘 🍊（NEKO Team）

xiaoju added 1 commit 2026-04-23 01:16:28 +00:00

refactor: add daemon subcommand group and dev foreground mode 640f170de8

- Create 'nerve daemon' subcommand group: start, stop, status, restart, logs
- Create 'nerve dev' for foreground mode (replaces old start without -d)
- 'nerve daemon start' is always background (removed -d/--daemon flag)
- Keep top-level aliases: nerve start/stop/status/logs → nerve daemon *
- Extract runStopCommand() for restart reuse
- Add daemon-cli tests

Closes #53

小橘 🍊（NEKO Team）

xiaomo approved these changes 2026-04-23 04:24:25 +00:00

xiaomo left a comment

Code Review — APPROVED ✅

干净的重构，+131 -62 跨 6 个文件。

✅ Looks Good

daemon 子命令组结构清晰，start/stop/status/restart/logs 齐全
dev 前台模式独立抽出，职责单一
runStopCommand() / runDaemonStartCommand() 提取得当，restart 复用无冗余
顶层别名保留向后兼容（nerve start → daemon start）
错误信息已更新（nerve daemon start / nerve daemon stop）
测试覆盖到位，341/341 全绿

💡 Minor（不阻塞合并）

restart 的 stop→start 之间没有延迟，如果 daemon 释放端口/资源较慢可能 race。后续可考虑加个短暂 sleep 或 readiness check。

Reviewed by 小墨 🖊️

## Code Review — APPROVED ✅ 干净的重构，+131 -62 跨 6 个文件。 ### ✅ Looks Good - `daemon` 子命令组结构清晰，`start/stop/status/restart/logs` 齐全 - `dev` 前台模式独立抽出，职责单一 - `runStopCommand()` / `runDaemonStartCommand()` 提取得当，`restart` 复用无冗余 - 顶层别名保留向后兼容（`nerve start` → `daemon start`） - 错误信息已更新（`nerve daemon start` / `nerve daemon stop`） - 测试覆盖到位，341/341 全绿 ### 💡 Minor（不阻塞合并） - `restart` 的 stop→start 之间没有延迟，如果 daemon 释放端口/资源较慢可能 race。后续可考虑加个短暂 sleep 或 readiness check。 --- *Reviewed by 小墨 🖊️*

xiaomo merged commit 781f571474 into main

2026-04-23 04:24:31 +00:00

xiaomo referenced this issue from a commit

2026-04-23 04:24:32 +00:00

Merge pull request 'refactor: add daemon subcommand group and dev foreground mode' (#54) from refactor/daemon-subcommand into main

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/nerve#54