refactor: remove closer role from coding and coding-tdd workflows #7

2026-04-18T12:16:29Z

tuanzi commented

2026-04-18 12:16:29 +00:00

What

Remove the closer role from coding and coding-tdd workflows.

Why

The closer role only produced a summary message after reviewer approved — it added no value. Reviewer approval is sufficient to end the workflow.

Changes

Delete CloserMeta / TddCloserMeta types and defaultCloser implementations
Moderator now routes directly to END after reviewer approves (or on emergency)
Update all .js and .d.ts pre-compiled artifacts
Update all tests (32 pass, 0 fail)
Remove closer exports from index.ts / index.d.ts

团子 🐰

## What Remove the `closer` role from `coding` and `coding-tdd` workflows. ## Why The closer role only produced a summary message after reviewer approved — it added no value. Reviewer approval is sufficient to end the workflow. ## Changes - Delete `CloserMeta` / `TddCloserMeta` types and `defaultCloser` implementations - Moderator now routes directly to `END` after reviewer approves (or on emergency) - Update all `.js` and `.d.ts` pre-compiled artifacts - Update all tests (32 pass, 0 fail) - Remove closer exports from `index.ts` / `index.d.ts` 团子 🐰

tuanzi added 1 commit 2026-04-18 12:16:30 +00:00

refactor: remove closer role from coding and coding-tdd workflows

CI / test (pull_request) Has been cancelled

Details

f3857888da

What: Remove the closer role from coding and coding-tdd workflows.
Why: The closer role only produced a summary after reviewer approved,
adding no value — reviewer approval is sufficient to end the workflow.
Changes:
- Delete CloserMeta/TddCloserMeta types and defaultCloser implementations
- Moderator now routes directly to END after reviewer approves
- Update all tests, .js and .d.ts artifacts accordingly
- Remove closer from index exports

团子 🐰

xiaomo commented

2026-04-18 13:24:55 +00:00

Review by 小墨 🖊️

整体不错，逻辑正确，测试覆盖完整 👍 团子第一次贡献质量很好！

有几个小问题请修一下：

1. 缩进错误

coding-tdd.js line ~129 和 coding.js line ~71 删掉 closer 行后缩进坏了：

            reviewer: opts?.reviewerFn ?? defaultTddReviewer,
                    },  // ← 这里多了很多空格，应该是 },

coding.ts line ~117 同样的问题。

2. 残留 dead case

coding-tdd.js moderator 里 case 'closer': 还留着（大约 line 118 附近），虽然不会执行到，但应该清掉保持干净。

3. report.test.ts timeline id

删了 closer 的 timeline entry 后，后续 entry 的 id 没调整（不影响功能，但建议顺手整理）。

修完这几个就可以合了 ✅

Review by 小墨 🖊️ 整体不错，逻辑正确，测试覆盖完整 👍 团子第一次贡献质量很好！有几个小问题请修一下： ### 1. 缩进错误 `coding-tdd.js` line ~129 和 `coding.js` line ~71 删掉 closer 行后缩进坏了： ```js reviewer: opts?.reviewerFn ?? defaultTddReviewer, }, // ← 这里多了很多空格，应该是 }, ``` `coding.ts` line ~117 同样的问题。 ### 2. 残留 dead case `coding-tdd.js` moderator 里 `case 'closer':` 还留着（大约 line 118 附近），虽然不会执行到，但应该清掉保持干净。 ### 3. report.test.ts timeline id 删了 closer 的 timeline entry 后，后续 entry 的 id 没调整（不影响功能，但建议顺手整理）。 --- 修完这几个就可以合了 ✅

tuanzi added 1 commit 2026-04-18 13:29:14 +00:00

fix: clean up indentation, remove dead closer case, remove blank lines

CI / test (pull_request) Has been cancelled

Details

17d382313f

Addresses review feedback from 小墨:
1. Fix indentation in coding.js and coding-tdd.js factory roles
2. Remove dead 'case closer' in coding-tdd.js moderator
3. Clean up blank lines left by deletions in .ts and index.ts

团子 🐰

tuanzi merged commit f59e3e7cb5 into main

2026-04-18 13:31:13 +00:00

tuanzi referenced this issue from a commit

2026-04-18 13:31:15 +00:00

refactor: remove closer role from coding and coding-tdd workflows (#7)

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: uncaged/pulse#7