uncaged/pulse
Archived
10
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove closer role from coding and coding-tdd workflows #7

Merged
tuanzi merged 2 commits from refactor/remove-closer-role into main 2026-04-18 13:31:13 +00:00
Conversation 1 Commits 2 Files Changed 11
+47 -125

2 Commits

Author SHA1 Message Date
tuanzi 17d382313f fix: clean up indentation, remove dead closer case, remove blank lines
CI / test (pull_request) Has been cancelled
Details 
Addresses review feedback from 小墨:
1. Fix indentation in coding.js and coding-tdd.js factory roles
2. Remove dead 'case closer' in coding-tdd.js moderator
3. Clean up blank lines left by deletions in .ts and index.ts

团子 🐰
 2026-04-18 13:29:10 +00:00
tuanzi f3857888da refactor: remove closer role from coding and coding-tdd workflows
CI / test (pull_request) Has been cancelled
Details 
What: Remove the closer role from coding and coding-tdd workflows.
Why: The closer role only produced a summary after reviewer approved,
adding no value — reviewer approval is sufficient to end the workflow.
Changes:
- Delete CloserMeta/TddCloserMeta types and defaultCloser implementations
- Moderator now routes directly to END after reviewer approves
- Update all tests, .js and .d.ts artifacts accordingly
- Remove closer from index exports

团子 🐰
 2026-04-18 12:16:02 +00:00